Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
brettw
CC:
chromium-reviews, sadrul, vmpstr+watch_chromium.org, wfh+watch_chromium.org, caitkp+watch_chromium.org, jam, rickyz+watch_chromium.org, darin-cc_chromium.org, grt+watch_chromium.org, tracing+reviews_chromium.org, kalyank, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Let some chromium_code targets build with -Wextra. To make warning flags between Windows and non-Windows clang consistent, I'd like to build chromium_code targets with -Wextra enabled. This fixes -Wextra warnings in about 14k of 31k build steps. Most of the warnings were about signed/unsigned mismatches; some were about "const"s that had no effect. (This CL does not contain the change to actually turn on -Wextra, only cleanups.) BUG=567877 TBR=content/common/sandbox Committed: https://crrev.com/9230c1d2dc9af55c573c54b64780a75cf418d896 Cr-Commit-Position: refs/heads/master@{#364232}

Patch Set 1 #

Patch Set 2 : content #

Patch Set 3 : content_unittests #

Patch Set 4 : content_browsertests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+427 lines, -372 lines) Patch
M base/file_version_info_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_version_info_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_util_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/message_loop/message_loop_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M base/process/process_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/profiler/native_stack_sampler_win.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M base/strings/utf_string_conversions_unittest.cc View 2 chunks +8 lines, -12 lines 0 comments Download
M base/test/test_reg_util_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_local_storage.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_local_storage.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M base/time/time_win_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M base/trace_event/trace_event_etw_export_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/win/enum_variant_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M base/win/event_trace_consumer_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M base/win/event_trace_controller_unittest.cc View 8 chunks +28 lines, -28 lines 0 comments Download
M base/win/event_trace_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M base/win/event_trace_provider_unittest.cc View 4 chunks +24 lines, -24 lines 0 comments Download
M base/win/iunknown_impl_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/win/registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/scoped_bstr_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M base/win/scoped_process_information_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/win/scoped_variant_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M base/win/startup_information.h View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 chunk +7 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/policy/policy_path_parser_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/app_command.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/installer_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/blacklist/blacklist.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M cloud_print/virtual_driver/win/install/setup.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/crash/content/app/hard_error_handler_win.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_win.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/accessibility/accessibility_win_browsertest.cc View 1 2 3 7 chunks +7 lines, -7 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gamepad/raw_input_data_fetcher_win.cc View 1 3 chunks +7 lines, -5 lines 0 comments Download
M content/browser/renderer_host/legacy_render_widget_host_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/system_message_window_win.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_window_delegate_unittest.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/npapi/webplugin_ime_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/cursors/webcursor.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/font_warmup_win_unittest.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M content/common/sandbox_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M crypto/symmetric_key_win.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/base/user_input_monitor_win.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M media/capture/video/win/video_capture_device_factory_win.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M media/capture/video/win/video_capture_device_mf_win.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M net/base/keygen_handler_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/cert/test_root_certs_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/ssl/client_cert_store_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/crosscall_params.h View 2 chunks +2 lines, -4 lines 0 comments Download
M sandbox/win/src/handle_closer_test.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M sandbox/win/src/interception_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M sandbox/win/src/ipc_unittest.cc View 11 chunks +15 lines, -15 lines 0 comments Download
M sandbox/win/src/job_unittest.cc View 11 chunks +40 lines, -27 lines 0 comments Download
M sandbox/win/src/policy_low_level_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M sandbox/win/src/policy_opcodes_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M sandbox/win/src/policy_target_test.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M sandbox/win/src/restricted_token_unittest.cc View 30 chunks +102 lines, -71 lines 0 comments Download
M sandbox/win/src/sandbox_policy_base.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/sandbox_policy_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/threadpool_unittest.cc View 3 chunks +13 lines, -12 lines 0 comments Download
M sandbox/win/src/win_utils_unittest.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M ui/base/ime/remote_input_method_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/native_theme/native_theme_win.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/delegate_execute_util_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Nico
5 years ago (2015-12-08 22:49:52 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507413003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507413003/20001
5 years ago (2015-12-09 15:40:48 UTC) #5
brettw
LGTM (I spot-checked)
5 years ago (2015-12-09 22:56:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507413003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507413003/60001
5 years ago (2015-12-09 22:59:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/127296)
5 years ago (2015-12-09 23:21:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507413003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507413003/60001
5 years ago (2015-12-09 23:28:31 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-10 00:36:33 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-10 00:37:17 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9230c1d2dc9af55c573c54b64780a75cf418d896
Cr-Commit-Position: refs/heads/master@{#364232}

Powered by Google App Engine
This is Rietveld 408576698