clang/win: Let some chromium_code targets build with -Wextra.

clang/win: Let some chromium_code targets build with -Wextra.

To make warning flags between Windows and non-Windows clang consistent,
I'd like to build chromium_code targets with -Wextra enabled.  This fixes
-Wextra warnings in about 14k of 31k build steps.

Most of the warnings were about signed/unsigned mismatches; some were about
"const"s that had no effect.

(This CL does not contain the change to actually turn on -Wextra, only
cleanups.)

BUG=567877
TBR=content/common/sandbox

Committed: https://crrev.com/9230c1d2dc9af55c573c54b64780a75cf418d896
Cr-Commit-Position: refs/heads/master@{#364232}

[Nico, 2015-12-08 22:45:55]

Description was changed from

==========
clang/win: Let some chromium_code targets build with -Wextra.

To make warning flags between Windows and non-Windows clang consistent,
I'd like to build chromium_code targets with -Wextra enabled.  This fixes
-Wextra warnings in about 10k of 30k build steps.

Most of the warnings were about signed/unsigned mismatches; some were about
"const"s that had no effect.

(This CL does not contain the change to actually turn on -Wextra, only
cleanups.)

BUG=567877
==========

to

==========
clang/win: Let some chromium_code targets build with -Wextra.

To make warning flags between Windows and non-Windows clang consistent,
I'd like to build chromium_code targets with -Wextra enabled.  This fixes
-Wextra warnings in about 14k of 31k build steps.

Most of the warnings were about signed/unsigned mismatches; some were about
"const"s that had no effect.

(This CL does not contain the change to actually turn on -Wextra, only
cleanups.)

BUG=567877
==========

[Nico, 2015-12-08 22:49:51]

thakis@chromium.org changed reviewers:
+ brettw@chromium.org

[Nico, 2015-12-09 15:38:43]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-09 15:40:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1507413003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1507413003/20001

[brettw, 2015-12-09 22:56:06]

LGTM (I spot-checked)

[Nico, 2015-12-09 22:57:42]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-12-09 22:59:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1507413003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1507413003/60001

[commit-bot: I haz the power, 2015-12-09 23:21:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 23:21:30]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2015-12-09 23:27:25]

Description was changed from

==========
clang/win: Let some chromium_code targets build with -Wextra.

To make warning flags between Windows and non-Windows clang consistent,
I'd like to build chromium_code targets with -Wextra enabled.  This fixes
-Wextra warnings in about 14k of 31k build steps.

Most of the warnings were about signed/unsigned mismatches; some were about
"const"s that had no effect.

(This CL does not contain the change to actually turn on -Wextra, only
cleanups.)

BUG=567877
==========

to

==========
clang/win: Let some chromium_code targets build with -Wextra.

To make warning flags between Windows and non-Windows clang consistent,
I'd like to build chromium_code targets with -Wextra enabled.  This fixes
-Wextra warnings in about 14k of 31k build steps.

Most of the warnings were about signed/unsigned mismatches; some were about
"const"s that had no effect.

(This CL does not contain the change to actually turn on -Wextra, only
cleanups.)

BUG=567877
TBR=content/common/sandbox
==========

[Nico, 2015-12-09 23:27:34]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-12-09 23:28:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1507413003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1507413003/60001

[commit-bot: I haz the power, 2015-12-10 00:36:32]

Description was changed from

==========
clang/win: Let some chromium_code targets build with -Wextra.

To make warning flags between Windows and non-Windows clang consistent,
I'd like to build chromium_code targets with -Wextra enabled.  This fixes
-Wextra warnings in about 14k of 31k build steps.

Most of the warnings were about signed/unsigned mismatches; some were about
"const"s that had no effect.

(This CL does not contain the change to actually turn on -Wextra, only
cleanups.)

BUG=567877
TBR=content/common/sandbox
==========

to

==========
clang/win: Let some chromium_code targets build with -Wextra.

To make warning flags between Windows and non-Windows clang consistent,
I'd like to build chromium_code targets with -Wextra enabled.  This fixes
-Wextra warnings in about 14k of 31k build steps.

Most of the warnings were about signed/unsigned mismatches; some were about
"const"s that had no effect.

(This CL does not contain the change to actually turn on -Wextra, only
cleanups.)

BUG=567877
TBR=content/common/sandbox
==========

[commit-bot: I haz the power, 2015-12-10 00:36:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-10 00:37:16]

Description was changed from

==========
clang/win: Let some chromium_code targets build with -Wextra.

To make warning flags between Windows and non-Windows clang consistent,
I'd like to build chromium_code targets with -Wextra enabled.  This fixes
-Wextra warnings in about 14k of 31k build steps.

Most of the warnings were about signed/unsigned mismatches; some were about
"const"s that had no effect.

(This CL does not contain the change to actually turn on -Wextra, only
cleanups.)

BUG=567877
TBR=content/common/sandbox
==========

to

==========
clang/win: Let some chromium_code targets build with -Wextra.

To make warning flags between Windows and non-Windows clang consistent,
I'd like to build chromium_code targets with -Wextra enabled.  This fixes
-Wextra warnings in about 14k of 31k build steps.

Most of the warnings were about signed/unsigned mismatches; some were about
"const"s that had no effect.

(This CL does not contain the change to actually turn on -Wextra, only
cleanups.)

BUG=567877
TBR=content/common/sandbox

Committed: https://crrev.com/9230c1d2dc9af55c573c54b64780a75cf418d896
Cr-Commit-Position: refs/heads/master@{#364232}
==========

[commit-bot: I haz the power, 2015-12-10 00:37:17]

Patchset 4 (id:??) landed as
https://crrev.com/9230c1d2dc9af55c573c54b64780a75cf418d896
Cr-Commit-Position: refs/heads/master@{#364232}