content/child/npapi/webplugin_delegate_impl_win.cc - Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/npapi/webplugin_delegate_impl_win.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: content_browsertests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/aura/overscroll_window_delegate_unittest.cc ('k') | content/child/npapi/webplugin_ime_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/npapi/webplugin_delegate_impl_win.cc

diff --git a/content/child/npapi/webplugin_delegate_impl_win.cc b/content/child/npapi/webplugin_delegate_impl_win.cc

index 8dd368721ad867f4d091a1191655893f96208362..582fdf79702d5a7d28f74fd4c94cc8e10c3c807c 100644

--- a/content/child/npapi/webplugin_delegate_impl_win.cc

+++ b/content/child/npapi/webplugin_delegate_impl_win.cc

@@ -169,7 +169,7 @@ std::wstring GetKeyPath(HKEY key) {

DWORD size = 0;

DWORD result = 0;

result = func(key, KeyNameInformation, 0, 0, &size);

- if (result != STATUS_BUFFER_TOO_SMALL)

+ if (result != static_cast<DWORD>(STATUS_BUFFER_TOO_SMALL))

return L"";

scoped_ptr<char[]> buffer(new char[size]);

@@ -177,7 +177,7 @@ std::wstring GetKeyPath(HKEY key) {

return L"";

result = func(key, KeyNameInformation, buffer.get(), size, &size);

- if (result != STATUS_SUCCESS)

+ if (result != static_cast<DWORD>(STATUS_SUCCESS))

return L"";

KEY_NAME_INFORMATION* info =