base/process/process_util_unittest.cc - Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/process/process_util_unittest.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: content_browsertests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/process/process_util_unittest.cc

diff --git a/base/process/process_util_unittest.cc b/base/process/process_util_unittest.cc

index 08144f2a18ec58789edd1cfdcbe988d411504cb4..140a65c2f460c17c694b87a9f95debca917c6ce1 100644

--- a/base/process/process_util_unittest.cc

+++ b/base/process/process_util_unittest.cc

@@ -278,7 +278,7 @@ TEST_F(ProcessUtilTest, MAYBE_GetTerminationStatusCrash) {

EXPECT_EQ(base::TERMINATION_STATUS_PROCESS_CRASHED, status);

#if defined(OS_WIN)

- EXPECT_EQ(0xc0000005, exit_code);

+ EXPECT_EQ(static_cast<int>(0xc0000005), exit_code);

#elif defined(OS_POSIX)

int signaled = WIFSIGNALED(exit_code);

EXPECT_NE(0, signaled);

« no previous file with comments | « base/message_loop/message_loop_unittest.cc ('k') | base/profiler/native_stack_sampler_win.cc » ('j') | no next file with comments »