cloud_print/virtual_driver/win/install/setup.cc - Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/virtual_driver/win/install/setup.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: content_browsertests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cloud_print/virtual_driver/win/install/setup.cc

diff --git a/cloud_print/virtual_driver/win/install/setup.cc b/cloud_print/virtual_driver/win/install/setup.cc

index 90322583a4494c2e34e1f5e7bea8466ce27478ea..c7fc3a5ef0a85c40dcbc717f50537312f017e365 100644

--- a/cloud_print/virtual_driver/win/install/setup.cc

+++ b/cloud_print/virtual_driver/win/install/setup.cc

@@ -193,7 +193,7 @@ UINT CALLBACK CabinetCallback(PVOID data,

if (notification == SPFILENOTIFY_FILEINCABINET) {

FILE_IN_CABINET_INFO* info =

reinterpret_cast<FILE_IN_CABINET_INFO*>(param1);

- for (int i = 0; i < arraysize(kDependencyList); i++) {

+ for (size_t i = 0; i < arraysize(kDependencyList); i++) {

base::FilePath base_name(info->NameInCabinet);

base_name = base_name.BaseName();

if (base::FilePath::CompareEqualIgnoreCase(base_name.value().c_str(),

« no previous file with comments | « chrome_elf/blacklist/blacklist.cc ('k') | components/crash/content/app/hard_error_handler_win.cc » ('j') | no next file with comments »