content/browser/gamepad/gamepad_platform_data_fetcher_win.cc - Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/gamepad/gamepad_platform_data_fetcher_win.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: content_browsertests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_win_unittest.cc ('k') | content/browser/gamepad/raw_input_data_fetcher_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/gamepad/gamepad_platform_data_fetcher_win.cc

diff --git a/content/browser/gamepad/gamepad_platform_data_fetcher_win.cc b/content/browser/gamepad/gamepad_platform_data_fetcher_win.cc

index 4882efbf62fdfbe29ba6b7ebd9c67af86179df57..f944eada356f4212a4a469fb8a3fbb5167e95974 100644

--- a/content/browser/gamepad/gamepad_platform_data_fetcher_win.cc

+++ b/content/browser/gamepad/gamepad_platform_data_fetcher_win.cc

@@ -34,7 +34,7 @@ float NormalizeXInputAxis(SHORT value) {

return ((value + 32768.f) / 32767.5f) - 1.f;

}

-const WebUChar* const GamepadSubTypeName(BYTE sub_type) {

+const WebUChar* GamepadSubTypeName(BYTE sub_type) {

switch (sub_type) {

case kDeviceSubTypeGamepad: return L"GAMEPAD";

case kDeviceSubTypeWheel: return L"WHEEL";