base/threading/thread_local_storage.h - Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/threading/thread_local_storage.h

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: content_browsertests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/threading/thread_local_storage.h

diff --git a/base/threading/thread_local_storage.h b/base/threading/thread_local_storage.h

index 195bff683c3bb8b7a3a23aec30f87ccfb25e7cbe..fa79edad5296e187250f8fa64183164c1fa8dfa7 100644

--- a/base/threading/thread_local_storage.h

+++ b/base/threading/thread_local_storage.h

@@ -27,7 +27,7 @@ class BASE_EXPORT PlatformThreadLocalStorage {

#if defined(OS_WIN)

typedef unsigned long TLSKey;

- enum { TLS_KEY_OUT_OF_INDEXES = TLS_OUT_OF_INDEXES };

+ enum : unsigned { TLS_KEY_OUT_OF_INDEXES = TLS_OUT_OF_INDEXES };

#elif defined(OS_POSIX)

typedef pthread_key_t TLSKey;

// The following is a "reserved key" which is used in our generic Chromium

« no previous file with comments | « base/test/test_reg_util_win_unittest.cc ('k') | base/threading/thread_local_storage.cc » ('j') | no next file with comments »