Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: sandbox/win/src/policy_low_level_unittest.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: content_browsertests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/win/src/job_unittest.cc ('k') | sandbox/win/src/policy_opcodes_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/src/policy_low_level_unittest.cc
diff --git a/sandbox/win/src/policy_low_level_unittest.cc b/sandbox/win/src/policy_low_level_unittest.cc
index 4081a5885d3d5feeac06c3a08161b34ca0fd57a8..88b9c439bfa993d188382d5f9ff82d04405c05b4 100644
--- a/sandbox/win/src/policy_low_level_unittest.cc
+++ b/sandbox/win/src/policy_low_level_unittest.cc
@@ -392,7 +392,7 @@ TEST(PolicyEngineTest, ThreeRulesTest) {
EXPECT_TRUE(pr_pipe.AddNumberMatch(IF, 2, FILE_ATTRIBUTE_NORMAL, EQUAL));
size_t opc1 = pr_pipe.GetOpcodeCount();
- EXPECT_EQ(3, opc1);
+ EXPECT_EQ(3u, opc1);
PolicyRule pr_dump(ASK_BROKER);
EXPECT_TRUE(pr_dump.AddStringMatch(IF, 0, L"\\\\/?/?\\*\\Crash Reports\\*",
@@ -401,7 +401,7 @@ TEST(PolicyEngineTest, ThreeRulesTest) {
EXPECT_TRUE(pr_dump.AddNumberMatch(IF, 2, FILE_ATTRIBUTE_NORMAL, EQUAL));
size_t opc2 = pr_dump.GetOpcodeCount();
- EXPECT_EQ(4, opc2);
+ EXPECT_EQ(4u, opc2);
PolicyRule pr_winexe(SIGNAL_ALARM);
EXPECT_TRUE(pr_winexe.AddStringMatch(IF, 0, L"\\\\/?/?\\C:\\Windows\\*.exe",
@@ -409,7 +409,7 @@ TEST(PolicyEngineTest, ThreeRulesTest) {
EXPECT_TRUE(pr_winexe.AddNumberMatch(IF, 2, FILE_ATTRIBUTE_NORMAL, EQUAL));
size_t opc3 = pr_winexe.GetOpcodeCount();
- EXPECT_EQ(3, opc3);
+ EXPECT_EQ(3u, opc3);
PolicyRule pr_adobe(GIVE_CACHED);
EXPECT_TRUE(pr_adobe.AddStringMatch(IF, 0, L"c:\\adobe\\ver?.?\\",
@@ -417,14 +417,14 @@ TEST(PolicyEngineTest, ThreeRulesTest) {
EXPECT_TRUE(pr_adobe.AddNumberMatch(IF, 2, FILE_ATTRIBUTE_NORMAL, EQUAL));
size_t opc4 = pr_adobe.GetOpcodeCount();
- EXPECT_EQ(4, opc4);
+ EXPECT_EQ(4u, opc4);
PolicyRule pr_none(GIVE_FIRST);
EXPECT_TRUE(pr_none.AddNumberMatch(IF, 2, FILE_ATTRIBUTE_READONLY, AND));
EXPECT_TRUE(pr_none.AddNumberMatch(IF, 2, FILE_ATTRIBUTE_SYSTEM, AND));
size_t opc5 = pr_none.GetOpcodeCount();
- EXPECT_EQ(2, opc5);
+ EXPECT_EQ(2u, opc5);
PolicyGlobal* policy = MakePolicyMemory();
« no previous file with comments | « sandbox/win/src/job_unittest.cc ('k') | sandbox/win/src/policy_opcodes_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698