Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Side by Side Diff: base/win/scoped_process_information_unittest.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: content_browsertests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/win/scoped_bstr_unittest.cc ('k') | base/win/scoped_variant_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <windows.h> 5 #include <windows.h>
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/process/kill.h" 10 #include "base/process/kill.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 process_info.Take(); 73 process_info.Take();
74 } 74 }
75 75
76 TEST_F(ScopedProcessInformationTest, TakeProcess) { 76 TEST_F(ScopedProcessInformationTest, TakeProcess) {
77 base::win::ScopedProcessInformation process_info; 77 base::win::ScopedProcessInformation process_info;
78 MockCreateProcess(&process_info); 78 MockCreateProcess(&process_info);
79 79
80 HANDLE process = process_info.TakeProcessHandle(); 80 HANDLE process = process_info.TakeProcessHandle();
81 EXPECT_EQ(kProcessHandle, process); 81 EXPECT_EQ(kProcessHandle, process);
82 EXPECT_EQ(NULL, process_info.process_handle()); 82 EXPECT_EQ(NULL, process_info.process_handle());
83 EXPECT_EQ(0, process_info.process_id()); 83 EXPECT_EQ(0u, process_info.process_id());
84 EXPECT_TRUE(process_info.IsValid()); 84 EXPECT_TRUE(process_info.IsValid());
85 process_info.Take(); 85 process_info.Take();
86 } 86 }
87 87
88 TEST_F(ScopedProcessInformationTest, TakeThread) { 88 TEST_F(ScopedProcessInformationTest, TakeThread) {
89 base::win::ScopedProcessInformation process_info; 89 base::win::ScopedProcessInformation process_info;
90 MockCreateProcess(&process_info); 90 MockCreateProcess(&process_info);
91 91
92 HANDLE thread = process_info.TakeThreadHandle(); 92 HANDLE thread = process_info.TakeThreadHandle();
93 EXPECT_EQ(kThreadHandle, thread); 93 EXPECT_EQ(kThreadHandle, thread);
94 EXPECT_EQ(NULL, process_info.thread_handle()); 94 EXPECT_EQ(NULL, process_info.thread_handle());
95 EXPECT_EQ(0, process_info.thread_id()); 95 EXPECT_EQ(0u, process_info.thread_id());
96 EXPECT_TRUE(process_info.IsValid()); 96 EXPECT_TRUE(process_info.IsValid());
97 process_info.Take(); 97 process_info.Take();
98 } 98 }
99 99
100 TEST_F(ScopedProcessInformationTest, TakeBoth) { 100 TEST_F(ScopedProcessInformationTest, TakeBoth) {
101 base::win::ScopedProcessInformation process_info; 101 base::win::ScopedProcessInformation process_info;
102 MockCreateProcess(&process_info); 102 MockCreateProcess(&process_info);
103 103
104 process_info.TakeProcessHandle(); 104 process_info.TakeProcessHandle();
105 process_info.TakeThreadHandle(); 105 process_info.TakeThreadHandle();
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 157
158 base::win::ScopedProcessInformation process_info; 158 base::win::ScopedProcessInformation process_info;
159 process_info.Set(base_struct); 159 process_info.Set(base_struct);
160 160
161 EXPECT_EQ(kProcessId, process_info.process_id()); 161 EXPECT_EQ(kProcessId, process_info.process_id());
162 EXPECT_EQ(kThreadId, process_info.thread_id()); 162 EXPECT_EQ(kThreadId, process_info.thread_id());
163 EXPECT_EQ(kProcessHandle, process_info.process_handle()); 163 EXPECT_EQ(kProcessHandle, process_info.process_handle());
164 EXPECT_EQ(kThreadHandle, process_info.thread_handle()); 164 EXPECT_EQ(kThreadHandle, process_info.thread_handle());
165 base_struct = process_info.Take(); 165 base_struct = process_info.Take();
166 } 166 }
OLDNEW
« no previous file with comments | « base/win/scoped_bstr_unittest.cc ('k') | base/win/scoped_variant_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698