Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Unified Diff: content/common/font_warmup_win_unittest.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: content_browsertests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/cursors/webcursor.cc ('k') | content/common/sandbox_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/font_warmup_win_unittest.cc
diff --git a/content/common/font_warmup_win_unittest.cc b/content/common/font_warmup_win_unittest.cc
index 80eb9e57b1f83f7dc33c94ac27f28dc8f7876a22..c6ba7b1257258ffec87e2b97b445269edcd829d8 100644
--- a/content/common/font_warmup_win_unittest.cc
+++ b/content/common/font_warmup_win_unittest.cc
@@ -256,9 +256,9 @@ TEST(GDIFontEmulationTest, CreateDeleteDCSuccess) {
HDC hdc = CreateCompatibleDC(0);
EXPECT_NE(hdc, nullptr);
- EXPECT_EQ(GetEmulatedGdiHandleCountForTesting(), 1);
+ EXPECT_EQ(1u, GetEmulatedGdiHandleCountForTesting());
EXPECT_TRUE(DeleteDC(hdc));
- EXPECT_EQ(GetEmulatedGdiHandleCountForTesting(), 0);
+ EXPECT_EQ(0u, GetEmulatedGdiHandleCountForTesting());
}
TEST(GDIFontEmulationTest, CreateUniqueDCSuccess) {
@@ -274,9 +274,9 @@ TEST(GDIFontEmulationTest, CreateUniqueDCSuccess) {
EXPECT_NE(hdc2, nullptr);
EXPECT_NE(hdc1, hdc2);
EXPECT_TRUE(DeleteDC(hdc2));
- EXPECT_EQ(GetEmulatedGdiHandleCountForTesting(), 1);
+ EXPECT_EQ(1u, GetEmulatedGdiHandleCountForTesting());
EXPECT_TRUE(DeleteDC(hdc1));
- EXPECT_EQ(GetEmulatedGdiHandleCountForTesting(), 0);
+ EXPECT_EQ(0u, GetEmulatedGdiHandleCountForTesting());
}
TEST(GDIFontEmulationTest, CreateFontSuccess) {
@@ -290,7 +290,7 @@ TEST(GDIFontEmulationTest, CreateFontSuccess) {
HFONT font = CreateFontIndirectW(&logfont);
EXPECT_NE(font, nullptr);
EXPECT_TRUE(DeleteObject(font));
- EXPECT_EQ(GetEmulatedGdiHandleCountForTesting(), 0);
+ EXPECT_EQ(0u, GetEmulatedGdiHandleCountForTesting());
}
TEST(GDIFontEmulationTest, CreateFontFailure) {
« no previous file with comments | « content/common/cursors/webcursor.cc ('k') | content/common/sandbox_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698