Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: chrome/installer/util/app_command.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: content_browsertests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/policy/policy_path_parser_win.cc ('k') | chrome/installer/util/installer_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/app_command.cc
diff --git a/chrome/installer/util/app_command.cc b/chrome/installer/util/app_command.cc
index 0d6be906888589ab5d11b97c33324ab3c8bbcdcf..66242b5fe325f8b97c6c6b16c3746e62c6a1df29 100644
--- a/chrome/installer/util/app_command.cc
+++ b/chrome/installer/util/app_command.cc
@@ -57,7 +57,7 @@ bool AppCommand::Initialize(const base::win::RegKey& key) {
command_line_.swap(cmd_line);
- for (int i = 0; i < arraysize(kNameBoolVars); ++i) {
+ for (size_t i = 0; i < arraysize(kNameBoolVars); ++i) {
DWORD value = 0; // Set default to false.
// Note: ReadValueDW only modifies out param on success.
key.ReadValueDW(kNameBoolVars[i].name, &value);
@@ -83,7 +83,7 @@ void AppCommand::AddWorkItems(HKEY predefined_root,
true)
->set_log_message("setting AppCommand CommandLine registry value");
- for (int i = 0; i < arraysize(kNameBoolVars); ++i) {
+ for (size_t i = 0; i < arraysize(kNameBoolVars); ++i) {
const wchar_t* var_name = kNameBoolVars[i].name;
bool var_data = this->*(kNameBoolVars[i].data);
« no previous file with comments | « chrome/browser/policy/policy_path_parser_win.cc ('k') | chrome/installer/util/installer_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698