Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2609)

Unified Diff: base/file_version_info_win.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: content_browsertests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/file_version_info_unittest.cc ('k') | base/files/file_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_version_info_win.cc
diff --git a/base/file_version_info_win.cc b/base/file_version_info_win.cc
index ca3e4b1fa3af6ac0d8511be8dac44675ad260c2a..a7dc216ce7bc7f3111d32076f7ca8a28ba04d80e 100644
--- a/base/file_version_info_win.cc
+++ b/base/file_version_info_win.cc
@@ -149,7 +149,7 @@ bool FileVersionInfoWin::is_official_build() {
bool FileVersionInfoWin::GetValue(const wchar_t* name,
std::wstring* value_str) {
WORD lang_codepage[8];
- int i = 0;
+ size_t i = 0;
// Use the language and codepage from the DLL.
lang_codepage[i++] = language_;
lang_codepage[i++] = code_page_;
« no previous file with comments | « base/file_version_info_unittest.cc ('k') | base/files/file_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698