Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: sandbox/win/src/win_utils_unittest.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: content_browsertests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/win/src/threadpool_unittest.cc ('k') | ui/base/ime/remote_input_method_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/src/win_utils_unittest.cc
diff --git a/sandbox/win/src/win_utils_unittest.cc b/sandbox/win/src/win_utils_unittest.cc
index 15da51b29cbfa9e54306037e2346d0f6df3799d5..fb72eb33859dc3f57d4b96834060c88da452a6c6 100644
--- a/sandbox/win/src/win_utils_unittest.cc
+++ b/sandbox/win/src/win_utils_unittest.cc
@@ -22,13 +22,16 @@ TEST(WinUtils, IsReparsePoint) {
ASSERT_TRUE(::DeleteFile(my_folder));
ASSERT_TRUE(::CreateDirectory(my_folder, NULL));
- EXPECT_EQ(ERROR_NOT_A_REPARSE_POINT, IsReparsePoint(my_folder));
+ EXPECT_EQ(static_cast<DWORD>(ERROR_NOT_A_REPARSE_POINT),
+ IsReparsePoint(my_folder));
base::string16 not_found = base::string16(my_folder) + L"\\foo\\bar";
- EXPECT_EQ(ERROR_NOT_A_REPARSE_POINT, IsReparsePoint(not_found));
+ EXPECT_EQ(static_cast<DWORD>(ERROR_NOT_A_REPARSE_POINT),
+ IsReparsePoint(not_found));
base::string16 new_file = base::string16(my_folder) + L"\\foo";
- EXPECT_EQ(ERROR_NOT_A_REPARSE_POINT, IsReparsePoint(new_file));
+ EXPECT_EQ(static_cast<DWORD>(ERROR_NOT_A_REPARSE_POINT),
+ IsReparsePoint(new_file));
// Replace the directory with a reparse point to %temp%.
HANDLE dir = ::CreateFile(my_folder, FILE_ALL_ACCESS,
@@ -39,7 +42,7 @@ TEST(WinUtils, IsReparsePoint) {
base::string16 temp_dir_nt = base::string16(L"\\??\\") + temp_directory;
EXPECT_TRUE(SetReparsePoint(dir, temp_dir_nt.c_str()));
- EXPECT_EQ(ERROR_SUCCESS, IsReparsePoint(new_file));
+ EXPECT_EQ(static_cast<DWORD>(ERROR_SUCCESS), IsReparsePoint(new_file));
EXPECT_TRUE(DeleteReparsePoint(dir));
EXPECT_TRUE(::CloseHandle(dir));
« no previous file with comments | « sandbox/win/src/threadpool_unittest.cc ('k') | ui/base/ime/remote_input_method_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698