Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1597)

Unified Diff: sandbox/win/src/policy_target_test.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: content_browsertests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/win/src/policy_opcodes_unittest.cc ('k') | sandbox/win/src/restricted_token_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/src/policy_target_test.cc
diff --git a/sandbox/win/src/policy_target_test.cc b/sandbox/win/src/policy_target_test.cc
index bb1f0b2ba38fd2fb94c780c26715a42c74975e2d..6e5bf156316e591a528223f727af2a718ca4c8f0 100644
--- a/sandbox/win/src/policy_target_test.cc
+++ b/sandbox/win/src/policy_target_test.cc
@@ -256,9 +256,10 @@ TEST(PolicyTargetTest, DesktopPolicy) {
if (result == SBOX_ALL_OK)
target.Set(temp_process_info);
- EXPECT_EQ(1, ::ResumeThread(target.thread_handle()));
+ EXPECT_EQ(1u, ::ResumeThread(target.thread_handle()));
- EXPECT_EQ(WAIT_TIMEOUT, ::WaitForSingleObject(target.process_handle(), 2000));
+ EXPECT_EQ(static_cast<DWORD>(WAIT_TIMEOUT),
+ ::WaitForSingleObject(target.process_handle(), 2000));
EXPECT_NE(::GetThreadDesktop(target.thread_id()),
::GetThreadDesktop(::GetCurrentThreadId()));
@@ -319,9 +320,10 @@ TEST(PolicyTargetTest, WinstaPolicy) {
if (result == SBOX_ALL_OK)
target.Set(temp_process_info);
- EXPECT_EQ(1, ::ResumeThread(target.thread_handle()));
+ EXPECT_EQ(1u, ::ResumeThread(target.thread_handle()));
- EXPECT_EQ(WAIT_TIMEOUT, ::WaitForSingleObject(target.process_handle(), 2000));
+ EXPECT_EQ(static_cast<DWORD>(WAIT_TIMEOUT),
+ ::WaitForSingleObject(target.process_handle(), 2000));
EXPECT_NE(::GetThreadDesktop(target.thread_id()),
::GetThreadDesktop(::GetCurrentThreadId()));
@@ -399,9 +401,9 @@ TEST(PolicyTargetTest, ShareHandleTest) {
if (result == SBOX_ALL_OK)
target.Set(temp_process_info);
- EXPECT_EQ(1, ::ResumeThread(target.thread_handle()));
+ EXPECT_EQ(1u, ::ResumeThread(target.thread_handle()));
- EXPECT_EQ(WAIT_TIMEOUT,
+ EXPECT_EQ(static_cast<DWORD>(WAIT_TIMEOUT),
::WaitForSingleObject(target.process_handle(), 2000));
EXPECT_TRUE(::TerminateProcess(target.process_handle(), 0));
« no previous file with comments | « sandbox/win/src/policy_opcodes_unittest.cc ('k') | sandbox/win/src/restricted_token_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698