Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Side by Side Diff: content/browser/accessibility/accessibility_tree_formatter_win.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: content_browsertests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/accessibility/accessibility_tree_formatter.h" 5 #include "content/browser/accessibility/accessibility_tree_formatter.h"
6 6
7 #include <oleacc.h> 7 #include <oleacc.h>
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 280 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 if (show_ids_) { 291 if (show_ids_) {
292 int id_value; 292 int id_value;
293 dict.GetInteger("id", &id_value); 293 dict.GetInteger("id", &id_value);
294 WriteAttribute(true, base::IntToString16(id_value), &line); 294 WriteAttribute(true, base::IntToString16(id_value), &line);
295 } 295 }
296 296
297 base::string16 role_value; 297 base::string16 role_value;
298 dict.GetString("role", &role_value); 298 dict.GetString("role", &role_value);
299 WriteAttribute(true, base::UTF16ToUTF8(role_value), &line); 299 WriteAttribute(true, base::UTF16ToUTF8(role_value), &line);
300 300
301 for (int i = 0; i < arraysize(ALL_ATTRIBUTES); i++) { 301 for (const char* attribute_name : ALL_ATTRIBUTES) {
302 const char* attribute_name = ALL_ATTRIBUTES[i];
303 const base::Value* value; 302 const base::Value* value;
304 if (!dict.Get(attribute_name, &value)) 303 if (!dict.Get(attribute_name, &value))
305 continue; 304 continue;
306 305
307 switch (value->GetType()) { 306 switch (value->GetType()) {
308 case base::Value::TYPE_STRING: { 307 case base::Value::TYPE_STRING: {
309 base::string16 string_value; 308 base::string16 string_value;
310 value->GetAsString(&string_value); 309 value->GetAsString(&string_value);
311 WriteAttribute(false, 310 WriteAttribute(false,
312 base::StringPrintf(L"%ls='%ls'", 311 base::StringPrintf(L"%ls='%ls'",
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 const std::string AccessibilityTreeFormatter::GetAllowString() { 397 const std::string AccessibilityTreeFormatter::GetAllowString() {
399 return "@WIN-ALLOW:"; 398 return "@WIN-ALLOW:";
400 } 399 }
401 400
402 // static 401 // static
403 const std::string AccessibilityTreeFormatter::GetDenyString() { 402 const std::string AccessibilityTreeFormatter::GetDenyString() {
404 return "@WIN-DENY:"; 403 return "@WIN-DENY:";
405 } 404 }
406 405
407 } // namespace content 406 } // namespace content
OLDNEW
« no previous file with comments | « components/crash/content/app/hard_error_handler_win.cc ('k') | content/browser/accessibility/accessibility_win_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698