Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Side by Side Diff: base/win/iunknown_impl_unittest.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: content_browsertests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/win/event_trace_provider_unittest.cc ('k') | base/win/registry_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/win/iunknown_impl.h" 5 #include "base/win/iunknown_impl.h"
6 6
7 #include "base/win/scoped_com_initializer.h" 7 #include "base/win/scoped_com_initializer.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace base { 10 namespace base {
(...skipping 12 matching lines...) Expand all
23 int TestIUnknownImplSubclass::instance_count = 0; 23 int TestIUnknownImplSubclass::instance_count = 0;
24 24
25 TEST(IUnknownImplTest, IUnknownImpl) { 25 TEST(IUnknownImplTest, IUnknownImpl) {
26 ScopedCOMInitializer com_initializer; 26 ScopedCOMInitializer com_initializer;
27 27
28 EXPECT_EQ(0, TestIUnknownImplSubclass::instance_count); 28 EXPECT_EQ(0, TestIUnknownImplSubclass::instance_count);
29 IUnknown* u = new TestIUnknownImplSubclass(); 29 IUnknown* u = new TestIUnknownImplSubclass();
30 30
31 EXPECT_EQ(1, TestIUnknownImplSubclass::instance_count); 31 EXPECT_EQ(1, TestIUnknownImplSubclass::instance_count);
32 32
33 EXPECT_EQ(1, u->AddRef()); 33 EXPECT_EQ(1u, u->AddRef());
34 EXPECT_EQ(1, u->AddRef()); 34 EXPECT_EQ(1u, u->AddRef());
35 35
36 IUnknown* other = NULL; 36 IUnknown* other = NULL;
37 EXPECT_EQ(E_NOINTERFACE, u->QueryInterface( 37 EXPECT_EQ(E_NOINTERFACE, u->QueryInterface(
38 IID_IDispatch, reinterpret_cast<void**>(&other))); 38 IID_IDispatch, reinterpret_cast<void**>(&other)));
39 EXPECT_EQ(S_OK, u->QueryInterface( 39 EXPECT_EQ(S_OK, u->QueryInterface(
40 IID_IUnknown, reinterpret_cast<void**>(&other))); 40 IID_IUnknown, reinterpret_cast<void**>(&other)));
41 other->Release(); 41 other->Release();
42 42
43 EXPECT_EQ(1, u->Release()); 43 EXPECT_EQ(1u, u->Release());
44 EXPECT_EQ(0, u->Release()); 44 EXPECT_EQ(0u, u->Release());
45 EXPECT_EQ(0, TestIUnknownImplSubclass::instance_count); 45 EXPECT_EQ(0, TestIUnknownImplSubclass::instance_count);
46 } 46 }
47 47
48 } // namespace win 48 } // namespace win
49 } // namespace base 49 } // namespace base
OLDNEW
« no previous file with comments | « base/win/event_trace_provider_unittest.cc ('k') | base/win/registry_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698