Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Side by Side Diff: base/win/scoped_variant_unittest.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: content_browsertests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/win/scoped_process_information_unittest.cc ('k') | base/win/startup_information.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/win/scoped_variant.h" 5 #include "base/win/scoped_variant.h"
6 #include "testing/gtest/include/gtest/gtest.h" 6 #include "testing/gtest/include/gtest/gtest.h"
7 7
8 namespace base { 8 namespace base {
9 namespace win { 9 namespace win {
10 10
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 var.Set(static_cast<int32>(123)); 137 var.Set(static_cast<int32>(123));
138 EXPECT_EQ(VT_I4, var.type()); 138 EXPECT_EQ(VT_I4, var.type());
139 EXPECT_EQ(123, V_I4(var.ptr())); 139 EXPECT_EQ(123, V_I4(var.ptr()));
140 140
141 var.Set(static_cast<int64>(123)); 141 var.Set(static_cast<int64>(123));
142 EXPECT_EQ(VT_I8, var.type()); 142 EXPECT_EQ(VT_I8, var.type());
143 EXPECT_EQ(123, V_I8(var.ptr())); 143 EXPECT_EQ(123, V_I8(var.ptr()));
144 144
145 var.Set(static_cast<uint8>(123)); 145 var.Set(static_cast<uint8>(123));
146 EXPECT_EQ(VT_UI1, var.type()); 146 EXPECT_EQ(VT_UI1, var.type());
147 EXPECT_EQ(123, V_UI1(var.ptr())); 147 EXPECT_EQ(123u, V_UI1(var.ptr()));
148 148
149 var.Set(static_cast<unsigned short>(123)); 149 var.Set(static_cast<unsigned short>(123));
150 EXPECT_EQ(VT_UI2, var.type()); 150 EXPECT_EQ(VT_UI2, var.type());
151 EXPECT_EQ(123, V_UI2(var.ptr())); 151 EXPECT_EQ(123u, V_UI2(var.ptr()));
152 152
153 var.Set(static_cast<uint32>(123)); 153 var.Set(static_cast<uint32>(123));
154 EXPECT_EQ(VT_UI4, var.type()); 154 EXPECT_EQ(VT_UI4, var.type());
155 EXPECT_EQ(123, V_UI4(var.ptr())); 155 EXPECT_EQ(123u, V_UI4(var.ptr()));
156 156
157 var.Set(static_cast<uint64>(123)); 157 var.Set(static_cast<uint64>(123));
158 EXPECT_EQ(VT_UI8, var.type()); 158 EXPECT_EQ(VT_UI8, var.type());
159 EXPECT_EQ(123, V_UI8(var.ptr())); 159 EXPECT_EQ(123u, V_UI8(var.ptr()));
160 160
161 var.Set(123.123f); 161 var.Set(123.123f);
162 EXPECT_EQ(VT_R4, var.type()); 162 EXPECT_EQ(VT_R4, var.type());
163 EXPECT_EQ(123.123f, V_R4(var.ptr())); 163 EXPECT_EQ(123.123f, V_R4(var.ptr()));
164 164
165 var.Set(static_cast<double>(123.123)); 165 var.Set(static_cast<double>(123.123));
166 EXPECT_EQ(VT_R8, var.type()); 166 EXPECT_EQ(VT_R8, var.type());
167 EXPECT_EQ(123.123, V_R8(var.ptr())); 167 EXPECT_EQ(123.123, V_R8(var.ptr()));
168 168
169 var.Set(true); 169 var.Set(true);
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 252
253 var.Set(sa); 253 var.Set(sa);
254 EXPECT_TRUE(ScopedVariant::IsLeakableVarType(var.type())); 254 EXPECT_TRUE(ScopedVariant::IsLeakableVarType(var.type()));
255 EXPECT_EQ(VT_ARRAY | VT_UI1, var.type()); 255 EXPECT_EQ(VT_ARRAY | VT_UI1, var.type());
256 EXPECT_EQ(sa, V_ARRAY(var.ptr())); 256 EXPECT_EQ(sa, V_ARRAY(var.ptr()));
257 // The array is destroyed in the destructor of var. 257 // The array is destroyed in the destructor of var.
258 } 258 }
259 259
260 } // namespace win 260 } // namespace win
261 } // namespace base 261 } // namespace base
OLDNEW
« no previous file with comments | « base/win/scoped_process_information_unittest.cc ('k') | base/win/startup_information.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698