chrome/installer/util/installer_state.cc - Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/installer_state.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: content_browsertests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/installer_state.cc

diff --git a/chrome/installer/util/installer_state.cc b/chrome/installer/util/installer_state.cc

index d6175e5e3bc166fac935e5d8e24904de3349ca75..90c868c18e200436f162e37dcc95decf59adaf45 100644

--- a/chrome/installer/util/installer_state.cc

+++ b/chrome/installer/util/installer_state.cc

@@ -521,7 +521,7 @@ void InstallerState::GetExistingExeVersions(

installer::kChromeOldExe,

};

- for (int i = 0; i < arraysize(kChromeFilenames); ++i) {

+ for (size_t i = 0; i < arraysize(kChromeFilenames); ++i) {

base::FilePath chrome_exe(target_path().Append(kChromeFilenames[i]));

scoped_ptr<FileVersionInfo> file_version_info(

FileVersionInfo::CreateFileVersionInfo(chrome_exe));

« no previous file with comments | « chrome/installer/util/app_command.cc ('k') | chrome_elf/blacklist/blacklist.cc » ('j') | no next file with comments »