content/browser/accessibility/browser_accessibility_win_unittest.cc - Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_win_unittest.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: content_browsertests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/accessibility_win_browsertest.cc ('k') | content/browser/gamepad/gamepad_platform_data_fetcher_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_win_unittest.cc

diff --git a/content/browser/accessibility/browser_accessibility_win_unittest.cc b/content/browser/accessibility/browser_accessibility_win_unittest.cc

index 29886bc1444aeaca4d40bf93634b33ac9a9cd9f8..eaa35582de74c9e0e6dde87892dcf4d96bb740c8 100644

--- a/content/browser/accessibility/browser_accessibility_win_unittest.cc

+++ b/content/browser/accessibility/browser_accessibility_win_unittest.cc

@@ -484,7 +484,7 @@ TEST_F(BrowserAccessibilityTest, TestTextBoundaries) {

TEST_F(BrowserAccessibilityTest, TestSimpleHypertext) {

const std::string text1_name = "One two three.";

const std::string text2_name = " Four five six.";

- const size_t text_name_len = text1_name.length() + text2_name.length();

+ const long text_name_len = text1_name.length() + text2_name.length();

ui::AXNodeData text1;

text1.id = 11;

@@ -567,7 +567,7 @@ TEST_F(BrowserAccessibilityTest, TestComplexHypertext) {

const base::string16 embed(1, BrowserAccessibilityWin::kEmbeddedCharacter);

const base::string16 root_hypertext =

text1_name + embed + text2_name + embed + embed + embed;

- const size_t root_hypertext_len = root_hypertext.length();

+ const long root_hypertext_len = root_hypertext.length();

ui::AXNodeData text1;

text1.id = 11;