Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: win8/delegate_execute/delegate_execute_util_unittest.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: content_browsertests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/win/hwnd_message_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: win8/delegate_execute/delegate_execute_util_unittest.cc
diff --git a/win8/delegate_execute/delegate_execute_util_unittest.cc b/win8/delegate_execute/delegate_execute_util_unittest.cc
index 63a5075bf6af8f0e03bb011a367f00459a7a4b7f..47916fdf6dde321c45aedeb4e9844985d684d671 100644
--- a/win8/delegate_execute/delegate_execute_util_unittest.cc
+++ b/win8/delegate_execute/delegate_execute_util_unittest.cc
@@ -47,16 +47,16 @@ TEST(DelegateExecuteUtil, MakeChromeCommandLineTest) {
this_exe,
delegate_execute::CommandLineFromParameters(NULL),
base::string16());
- EXPECT_EQ(1, cl.argv().size());
+ EXPECT_EQ(1u, cl.argv().size());
EXPECT_EQ(this_exe.value(), cl.GetProgram().value());
// Empty params with arg contains the arg.
cl = delegate_execute::MakeChromeCommandLine(
this_exe, delegate_execute::CommandLineFromParameters(NULL),
base::string16(kSomeArgument));
- EXPECT_EQ(2, cl.argv().size());
+ EXPECT_EQ(2u, cl.argv().size());
EXPECT_EQ(this_exe.value(), cl.GetProgram().value());
- EXPECT_EQ(1, cl.GetArgs().size());
+ EXPECT_EQ(1u, cl.GetArgs().size());
EXPECT_EQ(base::string16(kSomeArgument), cl.GetArgs()[0]);
// Params with switchs and args plus arg contains the arg.
@@ -66,11 +66,11 @@ TEST(DelegateExecuteUtil, MakeChromeCommandLineTest) {
base::ASCIIToUTF16(kSomeSwitch).c_str(),
kOtherArgument).c_str()),
base::string16(kSomeArgument));
- EXPECT_EQ(5, cl.argv().size());
+ EXPECT_EQ(5u, cl.argv().size());
EXPECT_EQ(this_exe.value(), cl.GetProgram().value());
EXPECT_TRUE(cl.HasSwitch(kSomeSwitch));
base::CommandLine::StringVector args(cl.GetArgs());
- EXPECT_EQ(2, args.size());
+ EXPECT_EQ(2u, args.size());
EXPECT_NE(
args.end(),
std::find(args.begin(), args.end(), base::string16(kOtherArgument)));
« no previous file with comments | « ui/views/win/hwnd_message_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698