net/ssl/client_cert_store_win.cc - Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ssl/client_cert_store_win.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: content_browsertests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/ssl/client_cert_store_win.cc

diff --git a/net/ssl/client_cert_store_win.cc b/net/ssl/client_cert_store_win.cc

index c8b750196ad415807a9c960ff4c89151e79a1256..1ebf02d79efb41c383a5a63732bd05b3aaaa881e 100644

--- a/net/ssl/client_cert_store_win.cc

+++ b/net/ssl/client_cert_store_win.cc

@@ -98,7 +98,7 @@ void GetClientCertsImpl(HCERTSTORE cert_store,

&find_by_issuer_para,

chain_context);

if (!chain_context) {

- if (GetLastError() != CRYPT_E_NOT_FOUND)

+ if (GetLastError() != static_cast<DWORD>(CRYPT_E_NOT_FOUND))

DPLOG(ERROR) << "CertFindChainInStore failed: ";

break;

}

« no previous file with comments | « net/cert/test_root_certs_win.cc ('k') | sandbox/win/src/crosscall_params.h » ('j') | no next file with comments »