Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3108)

Unified Diff: base/win/enum_variant_unittest.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: content_browsertests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/trace_event_etw_export_win.cc ('k') | base/win/event_trace_consumer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/win/enum_variant_unittest.cc
diff --git a/base/win/enum_variant_unittest.cc b/base/win/enum_variant_unittest.cc
index 99645a265023ac2db889c57bda0ae7d3193470ee..288c97ea559035725fcb1f5ba62101a0902167a8 100644
--- a/base/win/enum_variant_unittest.cc
+++ b/base/win/enum_variant_unittest.cc
@@ -31,7 +31,7 @@ TEST(EnumVariantTest, EmptyEnumVariant) {
VARIANT out_element;
ULONG out_received = 0;
EXPECT_EQ(S_FALSE, ev->Next(1, &out_element, &out_received));
- EXPECT_EQ(0, out_received);
+ EXPECT_EQ(0u, out_received);
EXPECT_EQ(S_FALSE, ev->Skip(1));
@@ -46,10 +46,10 @@ TEST(EnumVariantTest, EmptyEnumVariant) {
EXPECT_EQ(S_OK, ev2->Reset());
ULONG ev2_finalrefcount = ev2->Release();
- EXPECT_EQ(0, ev2_finalrefcount);
+ EXPECT_EQ(0u, ev2_finalrefcount);
ULONG ev_finalrefcount = ev->Release();
- EXPECT_EQ(0, ev_finalrefcount);
+ EXPECT_EQ(0u, ev_finalrefcount);
}
TEST(EnumVariantTest, SimpleEnumVariant) {
@@ -68,12 +68,12 @@ TEST(EnumVariantTest, SimpleEnumVariant) {
VARIANT out_element;
ULONG out_received = 0;
EXPECT_EQ(S_OK, ev->Next(1, &out_element, &out_received));
- EXPECT_EQ(1, out_received);
+ EXPECT_EQ(1u, out_received);
EXPECT_EQ(VT_I4, out_element.vt);
EXPECT_EQ(10, out_element.lVal);
EXPECT_EQ(S_OK, ev->Skip(1));
EXPECT_EQ(S_OK, ev->Next(1, &out_element, &out_received));
- EXPECT_EQ(1, out_received);
+ EXPECT_EQ(1u, out_received);
EXPECT_EQ(VT_I4, out_element.vt);
EXPECT_EQ(30, out_element.lVal);
EXPECT_EQ(S_FALSE, ev->Next(1, &out_element, &out_received));
@@ -82,7 +82,7 @@ TEST(EnumVariantTest, SimpleEnumVariant) {
VARIANT out_elements[3];
EXPECT_EQ(S_OK, ev->Reset());
EXPECT_EQ(S_OK, ev->Next(3, out_elements, &out_received));
- EXPECT_EQ(3, out_received);
+ EXPECT_EQ(3u, out_received);
EXPECT_EQ(VT_I4, out_elements[0].vt);
EXPECT_EQ(10, out_elements[0].lVal);
EXPECT_EQ(VT_I4, out_elements[1].vt);
@@ -98,7 +98,7 @@ TEST(EnumVariantTest, SimpleEnumVariant) {
EXPECT_EQ(S_FALSE, ev->Next(1, &out_element, &out_received));
EXPECT_EQ(S_OK, ev2->Reset());
EXPECT_EQ(S_OK, ev2->Next(3, out_elements, &out_received));
- EXPECT_EQ(3, out_received);
+ EXPECT_EQ(3u, out_received);
EXPECT_EQ(VT_I4, out_elements[0].vt);
EXPECT_EQ(10, out_elements[0].lVal);
EXPECT_EQ(VT_I4, out_elements[1].vt);
@@ -108,10 +108,10 @@ TEST(EnumVariantTest, SimpleEnumVariant) {
EXPECT_EQ(S_FALSE, ev2->Next(1, &out_element, &out_received));
ULONG ev2_finalrefcount = ev2->Release();
- EXPECT_EQ(0, ev2_finalrefcount);
+ EXPECT_EQ(0u, ev2_finalrefcount);
ULONG ev_finalrefcount = ev->Release();
- EXPECT_EQ(0, ev_finalrefcount);
+ EXPECT_EQ(0u, ev_finalrefcount);
}
} // namespace win
« no previous file with comments | « base/trace_event/trace_event_etw_export_win.cc ('k') | base/win/event_trace_consumer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698