content/common/sandbox_win.cc - Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/sandbox_win.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: content_browsertests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/sandbox_win.cc

diff --git a/content/common/sandbox_win.cc b/content/common/sandbox_win.cc

index a3554a23e8d5b18cbe6c8e1482c45274445d702b..856d12227a1835e244264b0a9c38c399f0b6d46c 100644

--- a/content/common/sandbox_win.cc

+++ b/content/common/sandbox_win.cc

@@ -814,7 +814,7 @@ base::Process StartSandboxedProcess(

delegate->PostSpawnTarget(target.process_handle());

- CHECK(ResumeThread(target.thread_handle()) != -1);

+ CHECK(ResumeThread(target.thread_handle()) != static_cast<DWORD>(-1));

return base::Process(target.TakeProcessHandle());

}

« no previous file with comments | « content/common/font_warmup_win_unittest.cc ('k') | crypto/symmetric_key_win.cc » ('j') | no next file with comments »