Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: sandbox/win/src/interception_unittest.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: content_browsertests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/win/src/handle_closer_test.cc ('k') | sandbox/win/src/ipc_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/src/interception_unittest.cc
diff --git a/sandbox/win/src/interception_unittest.cc b/sandbox/win/src/interception_unittest.cc
index 7ce5724bdc5e83542abc5499df3a7a09b30bdd7f..891c353385c3f2e62f1389e6b6afb690894f55d6 100644
--- a/sandbox/win/src/interception_unittest.cc
+++ b/sandbox/win/src/interception_unittest.cc
@@ -118,7 +118,7 @@ TEST(InterceptionManagerTest, GetGranularAlignedRandomOffset) {
max_val = std::max(val, max_val);
}
ASSERT_EQ(max_val, kAllocGranularity - kAlignment);
- ASSERT_EQ(min_val, 0);
+ ASSERT_EQ(0u, min_val);
ASSERT_EQ(min_nonzero_val, kAlignment);
}
@@ -179,7 +179,7 @@ TEST(InterceptionManagerTest, BufferLayout1) {
INTERCEPTION_EAT, function, OPEN_KEY_ID);
// Verify that all interceptions were added
- ASSERT_EQ(18, interceptions.interceptions_.size());
+ ASSERT_EQ(18u, interceptions.interceptions_.size());
size_t buffer_size = interceptions.GetBufferSize();
scoped_ptr<BYTE[]> local_buffer(new BYTE[buffer_size]);
@@ -195,7 +195,7 @@ TEST(InterceptionManagerTest, BufferLayout1) {
// first group remains on the list of interceptions (inside the object
// "interceptions"). There are 3 local interceptions (of ntdll); the
// other 15 have to be sent to the child to be performed "hot".
- EXPECT_EQ(3, interceptions.interceptions_.size());
+ EXPECT_EQ(3u, interceptions.interceptions_.size());
int num_dlls, num_functions, num_names;
WalkBuffer(local_buffer.get(), buffer_size, &num_dlls, &num_functions,
@@ -232,7 +232,7 @@ TEST(InterceptionManagerTest, BufferLayout2) {
INTERCEPTION_SMART_SIDESTEP, function,
OPEN_FILE_ID);
// Verify that all interceptions were added
- ASSERT_EQ(5, interceptions.interceptions_.size());
+ ASSERT_EQ(5u, interceptions.interceptions_.size());
size_t buffer_size = interceptions.GetBufferSize();
scoped_ptr<BYTE[]> local_buffer(new BYTE[buffer_size]);
@@ -245,7 +245,7 @@ TEST(InterceptionManagerTest, BufferLayout2) {
// group with the interceptions belonging to dlls that will be "hot"
// patched on the client. The second group lives on local_buffer, and the
// first group remains on the list of interceptions, in this case just one.
- EXPECT_EQ(1, interceptions.interceptions_.size());
+ EXPECT_EQ(1u, interceptions.interceptions_.size());
int num_dlls, num_functions, num_names;
WalkBuffer(local_buffer.get(), buffer_size, &num_dlls, &num_functions,
« no previous file with comments | « sandbox/win/src/handle_closer_test.cc ('k') | sandbox/win/src/ipc_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698