Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Side by Side Diff: ui/views/win/hwnd_message_handler.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: content_browsertests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/win/hwnd_message_handler.h" 5 #include "ui/views/win/hwnd_message_handler.h"
6 6
7 #include <dwmapi.h> 7 #include <dwmapi.h>
8 #include <oleacc.h> 8 #include <oleacc.h>
9 #include <shellapi.h> 9 #include <shellapi.h>
10 10
(...skipping 1395 matching lines...) Expand 10 before | Expand all | Expand 10 after
1406 LRESULT HWNDMessageHandler::OnGetObject(UINT message, 1406 LRESULT HWNDMessageHandler::OnGetObject(UINT message,
1407 WPARAM w_param, 1407 WPARAM w_param,
1408 LPARAM l_param) { 1408 LPARAM l_param) {
1409 LRESULT reference_result = static_cast<LRESULT>(0L); 1409 LRESULT reference_result = static_cast<LRESULT>(0L);
1410 1410
1411 // Only the lower 32 bits of l_param are valid when checking the object id 1411 // Only the lower 32 bits of l_param are valid when checking the object id
1412 // because it sometimes gets sign-extended incorrectly (but not always). 1412 // because it sometimes gets sign-extended incorrectly (but not always).
1413 DWORD obj_id = static_cast<DWORD>(static_cast<DWORD_PTR>(l_param)); 1413 DWORD obj_id = static_cast<DWORD>(static_cast<DWORD_PTR>(l_param));
1414 1414
1415 // Accessibility readers will send an OBJID_CLIENT message 1415 // Accessibility readers will send an OBJID_CLIENT message
1416 if (OBJID_CLIENT == obj_id) { 1416 if (static_cast<DWORD>(OBJID_CLIENT) == obj_id) {
1417 // Retrieve MSAA dispatch object for the root view. 1417 // Retrieve MSAA dispatch object for the root view.
1418 base::win::ScopedComPtr<IAccessible> root( 1418 base::win::ScopedComPtr<IAccessible> root(
1419 delegate_->GetNativeViewAccessible()); 1419 delegate_->GetNativeViewAccessible());
1420 1420
1421 // Create a reference that MSAA will marshall to the client. 1421 // Create a reference that MSAA will marshall to the client.
1422 reference_result = LresultFromObject(IID_IAccessible, w_param, 1422 reference_result = LresultFromObject(IID_IAccessible, w_param,
1423 static_cast<IAccessible*>(root.Detach())); 1423 static_cast<IAccessible*>(root.Detach()));
1424 } 1424 }
1425 1425
1426 return reference_result; 1426 return reference_result;
(...skipping 1050 matching lines...) Expand 10 before | Expand all | Expand 10 after
2477 ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 2477 ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT,
2478 0, 2478 0,
2479 0, 2479 0,
2480 event_time, 2480 event_time,
2481 1); 2481 1);
2482 2482
2483 touch_events->push_back(event); 2483 touch_events->push_back(event);
2484 } 2484 }
2485 2485
2486 } // namespace views 2486 } // namespace views
OLDNEW
« no previous file with comments | « ui/native_theme/native_theme_win.cc ('k') | win8/delegate_execute/delegate_execute_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698