Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1279)

Unified Diff: components/crash/content/app/hard_error_handler_win.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: content_browsertests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/content/app/hard_error_handler_win.cc
diff --git a/components/crash/content/app/hard_error_handler_win.cc b/components/crash/content/app/hard_error_handler_win.cc
index a31066632ea8faff16e7c8ef70c6446c138a49eb..21f24369437f593b5ca89a64a7cbc1925425fe51 100644
--- a/components/crash/content/app/hard_error_handler_win.cc
+++ b/components/crash/content/app/hard_error_handler_win.cc
@@ -33,8 +33,9 @@ DWORD FacilityFromException(DWORD exception_code) {
// This is not a generic function. It only works with some |nt_status| values.
// Check the strings here http://msdn.microsoft.com/en-us/library/cc704588.aspx
// before attempting to use this function.
-void RaiseHardErrorMsg(long nt_status, const std::string& p1,
- const std::string& p2) {
+void RaiseHardErrorMsg(DWORD nt_status,
+ const std::string& p1,
+ const std::string& p2) {
// If headless just exit silently.
if (GetCrashReporterClient()->IsRunningUnattended())
return;
@@ -95,7 +96,7 @@ bool HardErrorHandler(EXCEPTION_POINTERS* ex_info) {
if (!ex_info->ExceptionRecord)
return false;
- long exception = ex_info->ExceptionRecord->ExceptionCode;
+ DWORD exception = ex_info->ExceptionRecord->ExceptionCode;
if (exception == kExceptionModuleNotFound) {
ModuleNotFoundHardError(ex_info->ExceptionRecord);
return true;
« no previous file with comments | « cloud_print/virtual_driver/win/install/setup.cc ('k') | content/browser/accessibility/accessibility_tree_formatter_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698