base/files/file_util_unittest.cc - Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/file_util_unittest.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: content_browsertests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/files/file_util_unittest.cc

diff --git a/base/files/file_util_unittest.cc b/base/files/file_util_unittest.cc

index 933cb7f46e5c370c4fe2e8601d9e80184ce8f3bb..748301d80073537b9d3fa1dde26ef0e6e5563c3c 100644

--- a/base/files/file_util_unittest.cc

+++ b/base/files/file_util_unittest.cc

@@ -353,7 +353,8 @@ TEST_F(FileUtilTest, NormalizeFilePathReparsePoints) {

FilePath long_name = sub_a.Append(FilePath(long_name_str));

FilePath deep_file = long_name.Append(sub_long_rel).Append(deep_txt);

- ASSERT_EQ(MAX_PATH - kCreateDirLimit, deep_file.value().length());

+ ASSERT_EQ(static_cast<size_t>(MAX_PATH - kCreateDirLimit),

+ deep_file.value().length());

FilePath sub_long = deep_file.DirName();

ASSERT_TRUE(CreateDirectory(sub_long));

« no previous file with comments | « base/file_version_info_win.cc ('k') | base/message_loop/message_loop_unittest.cc » ('j') | no next file with comments »