Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: build/common.gypi

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: content_browsertests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/win/startup_information.h ('k') | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 5789 matching lines...) Expand 10 before | Expand all | Expand 10 after
5800 }, 5800 },
5801 }], 5801 }],
5802 ], 5802 ],
5803 'conditions': [ 5803 'conditions': [
5804 # Building with Clang on Windows is a work in progress and very 5804 # Building with Clang on Windows is a work in progress and very
5805 # experimental. See crbug.com/82385. 5805 # experimental. See crbug.com/82385.
5806 # Keep this in sync with the similar blocks in build/config/compiler /BUILD.gn 5806 # Keep this in sync with the similar blocks in build/config/compiler /BUILD.gn
5807 ['clang==1', { 5807 ['clang==1', {
5808 'VCCLCompilerTool': { 5808 'VCCLCompilerTool': {
5809 'AdditionalOptions': [ 5809 'AdditionalOptions': [
5810 # Don't warn about unused function parameters.
5811 # (This is also used on other platforms.)
5812 '-Wno-unused-parameter',
5813 # Don't warn about the "struct foo f = {0};" initialization
5814 # pattern.
5815 '-Wno-missing-field-initializers',
5816
5810 # Many files use intrinsics without including this header. 5817 # Many files use intrinsics without including this header.
5811 # TODO(hans): Fix those files, or move this to sub-GYPs. 5818 # TODO(hans): Fix those files, or move this to sub-GYPs.
5812 '/FIIntrin.h', 5819 '/FIIntrin.h',
5813 5820
5814 # TODO(hans): Make this list shorter eventually, http://crbug. com/504657 5821 # TODO(hans): Make this list shorter eventually, http://crbug. com/504657
5815 '-Qunused-arguments', # http://crbug.com/504658 5822 '-Qunused-arguments', # http://crbug.com/504658
5816 '-Wno-microsoft-enum-value', # http://crbug.com/505296 5823 '-Wno-microsoft-enum-value', # http://crbug.com/505296
5817 '-Wno-unknown-pragmas', # http://crbug.com/505314 5824 '-Wno-unknown-pragmas', # http://crbug.com/505314
5818 '-Wno-microsoft-cast', # http://crbug.com/550065 5825 '-Wno-microsoft-cast', # http://crbug.com/550065
5819 # Disable unused-value (crbug.com/505318) except 5826 # Disable unused-value (crbug.com/505318) except
(...skipping 554 matching lines...) Expand 10 before | Expand all | Expand 10 after
6374 # settings in target dicts. SYMROOT is a special case, because many other 6381 # settings in target dicts. SYMROOT is a special case, because many other
6375 # Xcode variables depend on it, including variables such as 6382 # Xcode variables depend on it, including variables such as
6376 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6383 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6377 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6384 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6378 # files to appear (when present) in the UI as actual files and not red 6385 # files to appear (when present) in the UI as actual files and not red
6379 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6386 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6380 # and therefore SYMROOT, needs to be set at the project level. 6387 # and therefore SYMROOT, needs to be set at the project level.
6381 'SYMROOT': '<(DEPTH)/xcodebuild', 6388 'SYMROOT': '<(DEPTH)/xcodebuild',
6382 }, 6389 },
6383 } 6390 }
OLDNEW
« no previous file with comments | « base/win/startup_information.h ('k') | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698