content/browser/accessibility/accessibility_tree_formatter_win.cc - Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/accessibility_tree_formatter_win.cc

Issue 1507413003: clang/win: Let some chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: content_browsertests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/crash/content/app/hard_error_handler_win.cc ('k') | content/browser/accessibility/accessibility_win_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/accessibility_tree_formatter_win.cc

diff --git a/content/browser/accessibility/accessibility_tree_formatter_win.cc b/content/browser/accessibility/accessibility_tree_formatter_win.cc

index c7ef471a616becfcf2ff70b0de13b0bae9f0cf6d..6277f430b50e31a6d4801e60fc48f26227ab2f25 100644

--- a/content/browser/accessibility/accessibility_tree_formatter_win.cc

+++ b/content/browser/accessibility/accessibility_tree_formatter_win.cc

@@ -298,8 +298,7 @@ base::string16 AccessibilityTreeFormatter::ToString(

dict.GetString("role", &role_value);

WriteAttribute(true, base::UTF16ToUTF8(role_value), &line);

- for (int i = 0; i < arraysize(ALL_ATTRIBUTES); i++) {

- const char* attribute_name = ALL_ATTRIBUTES[i];

+ for (const char* attribute_name : ALL_ATTRIBUTES) {

const base::Value* value;

if (!dict.Get(attribute_name, &value))

continue;