Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Don’t use using directives (“using namespace”) in tests. The contents of tests are moved into the namespace crashpad::test::(anonymous namespace). https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespaces R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/6d1af6922fc8326eeb5f17941afa1b2f037ba379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -113 lines) Patch
M client/capture_context_mac_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M client/simple_string_dictionary_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M minidump/minidump_file_writer_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M minidump/minidump_memory_writer_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M minidump/minidump_misc_info_writer_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M minidump/minidump_module_writer_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M minidump/minidump_string_writer_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M minidump/minidump_system_info_writer_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M minidump/minidump_writable_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M snapshot/cpu_context_mac_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M snapshot/system_snapshot_mac_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M util/file/string_file_writer_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/mac/checked_mach_address_range_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/mac/launchd_test.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M util/mac/mac_util_test.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M util/mac/mach_o_image_reader_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/mac/mach_o_image_segment_reader_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/mac/process_reader_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M util/mac/process_types_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/mac/service_management_test.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M util/mach/exc_client_variants_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M util/mach/exc_server_variants_test.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M util/mach/exception_behaviors_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/mach/exception_ports_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M util/mach/mach_extensions_test.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M util/mach/mach_message_server_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M util/mach/symbolic_constants_mach_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/mach/task_memory_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M util/misc/clock_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/misc/initialization_state_dcheck_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/misc/initialization_state_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/misc/scoped_forbid_return_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/misc/uuid_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/numeric/checked_range_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/numeric/in_range_cast_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/numeric/int128_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/posix/process_util_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/posix/symbolic_constants_posix_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/stdlib/string_number_conversion_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/stdlib/strlcpy_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/stdlib/strnlen_test.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M util/synchronization/semaphore_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/test/executable_path_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M util/test/mac/mach_multiprocess.cc View 2 chunks +1 line, -3 lines 0 comments Download
M util/test/mac/mach_multiprocess_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M util/test/multiprocess.cc View 2 chunks +1 line, -3 lines 0 comments Download
M util/test/multiprocess_exec.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M util/test/multiprocess_exec_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M util/test/multiprocess_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
Also, https://codereview.chromium.org/627273004/.
6 years, 2 months ago (2014-10-07 17:47:50 UTC) #2
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-07 21:13:51 UTC) #3
Mark Mentovai
6 years, 2 months ago (2014-10-07 21:29:02 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6d1af6922fc8326eeb5f17941afa1b2f037ba379 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698