Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: util/mach/task_memory_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/mach/symbolic_constants_mach_test.cc ('k') | util/misc/clock_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mach/task_memory_test.cc
diff --git a/util/mach/task_memory_test.cc b/util/mach/task_memory_test.cc
index 3ee813abb3d9b9eec6c488bd91b8558f1b302c4c..523e95a591fd9250a89a7faae11eaf46883e4038 100644
--- a/util/mach/task_memory_test.cc
+++ b/util/mach/task_memory_test.cc
@@ -26,11 +26,10 @@
#include "gtest/gtest.h"
#include "util/test/mac/mach_errors.h"
+namespace crashpad {
+namespace test {
namespace {
-using namespace crashpad;
-using namespace crashpad::test;
-
TEST(TaskMemory, ReadSelf) {
vm_address_t address = 0;
const vm_size_t kSize = 4 * PAGE_SIZE;
@@ -552,3 +551,5 @@ TEST(TaskMemory, MappedMemoryReadCString) {
}
} // namespace
+} // namespace test
+} // namespace crashpad
« no previous file with comments | « util/mach/symbolic_constants_mach_test.cc ('k') | util/misc/clock_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698