Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: util/mach/symbolic_constants_mach_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/mach/mach_message_server_test.cc ('k') | util/mach/task_memory_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/mach/symbolic_constants_mach.h" 15 #include "util/mach/symbolic_constants_mach.h"
16 16
17 #include <mach/mach.h> 17 #include <mach/mach.h>
18 #include <string.h> 18 #include <string.h>
19 19
20 #include "base/basictypes.h" 20 #include "base/basictypes.h"
21 #include "base/strings/string_piece.h" 21 #include "base/strings/string_piece.h"
22 #include "base/strings/stringprintf.h" 22 #include "base/strings/stringprintf.h"
23 #include "gtest/gtest.h" 23 #include "gtest/gtest.h"
24 #include "util/mach/mach_extensions.h" 24 #include "util/mach/mach_extensions.h"
25 25
26 #define NUL_TEST_DATA(string) { string, arraysize(string) - 1 } 26 #define NUL_TEST_DATA(string) { string, arraysize(string) - 1 }
27 27
28 namespace crashpad {
29 namespace test {
28 namespace { 30 namespace {
29 31
30 using namespace crashpad;
31
32 // Options to use for normal tests, those that don’t require kAllowOr. 32 // Options to use for normal tests, those that don’t require kAllowOr.
33 const StringToSymbolicConstantOptions kNormalOptions[] = { 33 const StringToSymbolicConstantOptions kNormalOptions[] = {
34 0, 34 0,
35 kAllowFullName, 35 kAllowFullName,
36 kAllowShortName, 36 kAllowShortName,
37 kAllowFullName | kAllowShortName, 37 kAllowFullName | kAllowShortName,
38 kAllowNumber, 38 kAllowNumber,
39 kAllowFullName | kAllowNumber, 39 kAllowFullName | kAllowNumber,
40 kAllowShortName | kAllowNumber, 40 kAllowShortName | kAllowNumber,
41 kAllowFullName | kAllowShortName | kAllowNumber, 41 kAllowFullName | kAllowShortName | kAllowNumber,
(...skipping 1013 matching lines...) Expand 10 before | Expand all | Expand 10 after
1055 { 1055 {
1056 SCOPED_TRACE("trailing_NUL_short_new"); 1056 SCOPED_TRACE("trailing_NUL_short_new");
1057 TestStringToThreadStateFlavor(base::StringPiece("FLAVOR_LIST_NEWS", 15), 1057 TestStringToThreadStateFlavor(base::StringPiece("FLAVOR_LIST_NEWS", 15),
1058 kAllowShortName, 1058 kAllowShortName,
1059 true, 1059 true,
1060 THREAD_STATE_FLAVOR_LIST_NEW); 1060 THREAD_STATE_FLAVOR_LIST_NEW);
1061 } 1061 }
1062 } 1062 }
1063 1063
1064 } // namespace 1064 } // namespace
1065 } // namespace test
1066 } // namespace crashpad
OLDNEW
« no previous file with comments | « util/mach/mach_message_server_test.cc ('k') | util/mach/task_memory_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698