Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Unified Diff: util/stdlib/string_number_conversion_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/posix/symbolic_constants_posix_test.cc ('k') | util/stdlib/strlcpy_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/stdlib/string_number_conversion_test.cc
diff --git a/util/stdlib/string_number_conversion_test.cc b/util/stdlib/string_number_conversion_test.cc
index ef1376c76700dce3595cdbfeca728d7f9780a4d7..ec0d44ae301dd267381923ce819a03649279d751 100644
--- a/util/stdlib/string_number_conversion_test.cc
+++ b/util/stdlib/string_number_conversion_test.cc
@@ -19,10 +19,10 @@
#include <limits>
+namespace crashpad {
+namespace test {
namespace {
-using namespace crashpad;
-
TEST(StringNumberConversion, StringToInt) {
const struct {
const char* string;
@@ -216,3 +216,5 @@ TEST(StringNumberConversion, StringToUnsignedInt) {
}
} // namespace
+} // namespace test
+} // namespace crashpad
« no previous file with comments | « util/posix/symbolic_constants_posix_test.cc ('k') | util/stdlib/strlcpy_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698