Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Side by Side Diff: minidump/minidump_writable_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_system_info_writer_test.cc ('k') | snapshot/cpu_context_mac_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "minidump/minidump_writable.h" 15 #include "minidump/minidump_writable.h"
16 16
17 #include <string> 17 #include <string>
18 #include <vector> 18 #include <vector>
19 19
20 #include "base/basictypes.h" 20 #include "base/basictypes.h"
21 #include "gtest/gtest.h" 21 #include "gtest/gtest.h"
22 #include "util/file/string_file_writer.h" 22 #include "util/file/string_file_writer.h"
23 23
24 namespace crashpad {
25 namespace test {
24 namespace { 26 namespace {
25 27
26 using namespace crashpad;
27
28 class BaseTestMinidumpWritable : public crashpad::internal::MinidumpWritable { 28 class BaseTestMinidumpWritable : public crashpad::internal::MinidumpWritable {
29 public: 29 public:
30 BaseTestMinidumpWritable() 30 BaseTestMinidumpWritable()
31 : MinidumpWritable(), 31 : MinidumpWritable(),
32 children_(), 32 children_(),
33 expected_offset_(-1), 33 expected_offset_(-1),
34 alignment_(0), 34 alignment_(0),
35 phase_(kPhaseEarly), 35 phase_(kPhaseEarly),
36 has_alignment_(false), 36 has_alignment_(false),
37 has_phase_(false), 37 has_phase_(false),
(...skipping 788 matching lines...) Expand 10 before | Expand all | Expand 10 after
826 EXPECT_STREQ("p", ldd->string); 826 EXPECT_STREQ("p", ldd->string);
827 ldd = LDDAtIndex(writer.string(), 48); 827 ldd = LDDAtIndex(writer.string(), 48);
828 EXPECT_EQ(10u, ldd->location_descriptor.DataSize); 828 EXPECT_EQ(10u, ldd->location_descriptor.DataSize);
829 EXPECT_EQ(12u, ldd->location_descriptor.Rva); 829 EXPECT_EQ(12u, ldd->location_descriptor.Rva);
830 EXPECT_STREQ("o", ldd->string); 830 EXPECT_STREQ("o", ldd->string);
831 parent.Verify(); 831 parent.Verify();
832 } 832 }
833 } 833 }
834 834
835 } // namespace 835 } // namespace
836 } // namespace test
837 } // namespace crashpad
OLDNEW
« no previous file with comments | « minidump/minidump_system_info_writer_test.cc ('k') | snapshot/cpu_context_mac_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698