Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: util/test/multiprocess_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/test/multiprocess_exec_test.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/test/multiprocess.h" 15 #include "util/test/multiprocess.h"
16 16
17 #include <stdlib.h> 17 #include <stdlib.h>
18 #include <sys/signal.h> 18 #include <sys/signal.h>
19 #include <unistd.h> 19 #include <unistd.h>
20 20
21 #include "base/basictypes.h" 21 #include "base/basictypes.h"
22 #include "gtest/gtest.h" 22 #include "gtest/gtest.h"
23 #include "util/file/fd_io.h" 23 #include "util/file/fd_io.h"
24 24
25 namespace crashpad {
26 namespace test {
25 namespace { 27 namespace {
26 28
27 using namespace crashpad;
28 using namespace crashpad::test;
29
30 class TestMultiprocess final : public Multiprocess { 29 class TestMultiprocess final : public Multiprocess {
31 public: 30 public:
32 TestMultiprocess() : Multiprocess() {} 31 TestMultiprocess() : Multiprocess() {}
33 32
34 ~TestMultiprocess() {} 33 ~TestMultiprocess() {}
35 34
36 private: 35 private:
37 // Multiprocess: 36 // Multiprocess:
38 37
39 virtual void MultiprocessParent() override { 38 virtual void MultiprocessParent() override {
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 } 284 }
286 285
287 TEST(MultiprocessDeathTest, ChildClosesReadAndWritePipe) { 286 TEST(MultiprocessDeathTest, ChildClosesReadAndWritePipe) {
288 TestMultiprocessClosePipe multiprocess( 287 TestMultiprocessClosePipe multiprocess(
289 TestMultiprocessClosePipe::kChildCloses, 288 TestMultiprocessClosePipe::kChildCloses,
290 TestMultiprocessClosePipe::kReadAndWriteClose); 289 TestMultiprocessClosePipe::kReadAndWriteClose);
291 multiprocess.Run(); 290 multiprocess.Run();
292 } 291 }
293 292
294 } // namespace 293 } // namespace
294 } // namespace test
295 } // namespace crashpad
OLDNEW
« no previous file with comments | « util/test/multiprocess_exec_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698