Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: util/test/multiprocess_exec_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/test/multiprocess_exec.cc ('k') | util/test/multiprocess_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/test/multiprocess_exec.h" 15 #include "util/test/multiprocess_exec.h"
16 16
17 #include <unistd.h> 17 #include <unistd.h>
18 18
19 #include "base/basictypes.h" 19 #include "base/basictypes.h"
20 #include "gtest/gtest.h" 20 #include "gtest/gtest.h"
21 #include "util/file/fd_io.h" 21 #include "util/file/fd_io.h"
22 #include "util/test/executable_path.h" 22 #include "util/test/executable_path.h"
23 23
24 namespace crashpad {
25 namespace test {
24 namespace { 26 namespace {
25 27
26 using namespace crashpad;
27 using namespace crashpad::test;
28
29 class TestMultiprocessExec final : public MultiprocessExec { 28 class TestMultiprocessExec final : public MultiprocessExec {
30 public: 29 public:
31 TestMultiprocessExec() : MultiprocessExec() {} 30 TestMultiprocessExec() : MultiprocessExec() {}
32 31
33 ~TestMultiprocessExec() {} 32 ~TestMultiprocessExec() {}
34 33
35 private: 34 private:
36 virtual void MultiprocessParent() override { 35 virtual void MultiprocessParent() override {
37 char c = 'z'; 36 char c = 'z';
38 CheckedWriteFD(WritePipeFD(), &c, 1); 37 CheckedWriteFD(WritePipeFD(), &c, 1);
39 38
40 CheckedReadFD(ReadPipeFD(), &c, 1); 39 CheckedReadFD(ReadPipeFD(), &c, 1);
41 EXPECT_EQ('Z', c); 40 EXPECT_EQ('Z', c);
42 } 41 }
43 42
44 DISALLOW_COPY_AND_ASSIGN(TestMultiprocessExec); 43 DISALLOW_COPY_AND_ASSIGN(TestMultiprocessExec);
45 }; 44 };
46 45
47 TEST(MultiprocessExec, MultiprocessExec) { 46 TEST(MultiprocessExec, MultiprocessExec) {
48 TestMultiprocessExec multiprocess_exec; 47 TestMultiprocessExec multiprocess_exec;
49 base::FilePath test_executable = ExecutablePath(); 48 base::FilePath test_executable = ExecutablePath();
50 std::string child_test_executable = 49 std::string child_test_executable =
51 test_executable.value() + "_multiprocess_exec_test_child"; 50 test_executable.value() + "_multiprocess_exec_test_child";
52 multiprocess_exec.SetChildCommand(child_test_executable, NULL); 51 multiprocess_exec.SetChildCommand(child_test_executable, NULL);
53 multiprocess_exec.Run(); 52 multiprocess_exec.Run();
54 } 53 }
55 54
56 } // namespace 55 } // namespace
56 } // namespace test
57 } // namespace crashpad
OLDNEW
« no previous file with comments | « util/test/multiprocess_exec.cc ('k') | util/test/multiprocess_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698