Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Side by Side Diff: minidump/minidump_memory_writer_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_file_writer_test.cc ('k') | minidump/minidump_misc_info_writer_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "minidump/minidump_memory_writer.h" 15 #include "minidump/minidump_memory_writer.h"
16 16
17 #include <dbghelp.h> 17 #include <dbghelp.h>
18 #include <stdint.h> 18 #include <stdint.h>
19 19
20 #include "base/basictypes.h" 20 #include "base/basictypes.h"
21 #include "gtest/gtest.h" 21 #include "gtest/gtest.h"
22 #include "minidump/minidump_extensions.h" 22 #include "minidump/minidump_extensions.h"
23 #include "minidump/minidump_file_writer.h" 23 #include "minidump/minidump_file_writer.h"
24 #include "minidump/minidump_stream_writer.h" 24 #include "minidump/minidump_stream_writer.h"
25 #include "minidump/minidump_test_util.h" 25 #include "minidump/minidump_test_util.h"
26 #include "util/file/string_file_writer.h" 26 #include "util/file/string_file_writer.h"
27 27
28 namespace crashpad {
29 namespace test {
28 namespace { 30 namespace {
29 31
30 using namespace crashpad;
31 using namespace crashpad::test;
32
33 const MinidumpStreamType kBogusStreamType = 32 const MinidumpStreamType kBogusStreamType =
34 static_cast<MinidumpStreamType>(1234); 33 static_cast<MinidumpStreamType>(1234);
35 34
36 // expected_streams is the expected number of streams in the file. The memory 35 // expected_streams is the expected number of streams in the file. The memory
37 // list must be the last stream. If there is another stream, it must come first, 36 // list must be the last stream. If there is another stream, it must come first,
38 // have stream type kBogusStreamType, and have zero-length data. 37 // have stream type kBogusStreamType, and have zero-length data.
39 void GetMemoryListStream(const std::string& file_contents, 38 void GetMemoryListStream(const std::string& file_contents,
40 const MINIDUMP_MEMORY_LIST** memory_list, 39 const MINIDUMP_MEMORY_LIST** memory_list,
41 const uint32_t expected_streams) { 40 const uint32_t expected_streams) {
42 const size_t kDirectoryOffset = sizeof(MINIDUMP_HEADER); 41 const size_t kDirectoryOffset = sizeof(MINIDUMP_HEADER);
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
382 memory_list->MemoryRanges[0].Memory.DataSize; 381 memory_list->MemoryRanges[0].Memory.DataSize;
383 ExpectMemoryDescriptorAndContents(&expected, 382 ExpectMemoryDescriptorAndContents(&expected,
384 &memory_list->MemoryRanges[1], 383 &memory_list->MemoryRanges[1],
385 file_writer.string(), 384 file_writer.string(),
386 kValue2, 385 kValue2,
387 true); 386 true);
388 } 387 }
389 } 388 }
390 389
391 } // namespace 390 } // namespace
391 } // namespace test
392 } // namespace crashpad
OLDNEW
« no previous file with comments | « minidump/minidump_file_writer_test.cc ('k') | minidump/minidump_misc_info_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698