Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: util/mac/service_management_test.mm

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/mac/process_types_test.cc ('k') | util/mach/exc_client_variants_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mac/service_management_test.mm
diff --git a/util/mac/service_management_test.mm b/util/mac/service_management_test.mm
index 9ca2e15ae61df9fd0233108f1f6bb3b64456f29c..278272165113a8bb8731c0fdf7b460e3a52ab4c6 100644
--- a/util/mac/service_management_test.mm
+++ b/util/mac/service_management_test.mm
@@ -30,10 +30,10 @@
#include "util/posix/process_util.h"
#include "util/stdlib/objc.h"
+namespace crashpad {
+namespace test {
namespace {
-using namespace crashpad;
-
// Ensures that the process with the specified PID is running, identifying it by
// requiring that its argv[argc - 1] compare equal to last_arg.
void ExpectProcessIsRunning(pid_t pid, std::string& last_arg) {
@@ -156,3 +156,5 @@ TEST(ServiceManagement, SubmitRemoveJob) {
}
} // namespace
+} // namespace test
+} // namespace crashpad
« no previous file with comments | « util/mac/process_types_test.cc ('k') | util/mach/exc_client_variants_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698