Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: minidump/minidump_system_info_writer_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_string_writer_test.cc ('k') | minidump/minidump_writable_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "minidump/minidump_system_info_writer.h" 15 #include "minidump/minidump_system_info_writer.h"
16 16
17 #include <dbghelp.h> 17 #include <dbghelp.h>
18 #include <string.h> 18 #include <string.h>
19 19
20 #include <string> 20 #include <string>
21 21
22 #include "gtest/gtest.h" 22 #include "gtest/gtest.h"
23 #include "minidump/minidump_file_writer.h" 23 #include "minidump/minidump_file_writer.h"
24 #include "minidump/minidump_test_util.h" 24 #include "minidump/minidump_test_util.h"
25 #include "util/file/string_file_writer.h" 25 #include "util/file/string_file_writer.h"
26 26
27 namespace crashpad {
28 namespace test {
27 namespace { 29 namespace {
28 30
29 using namespace crashpad;
30 using namespace crashpad::test;
31
32 void GetSystemInfoStream(const std::string& file_contents, 31 void GetSystemInfoStream(const std::string& file_contents,
33 size_t csd_version_length, 32 size_t csd_version_length,
34 const MINIDUMP_SYSTEM_INFO** system_info, 33 const MINIDUMP_SYSTEM_INFO** system_info,
35 const MINIDUMP_STRING** csd_version) { 34 const MINIDUMP_STRING** csd_version) {
36 // The expected number of bytes for the CSD version’s MINIDUMP_STRING::Buffer. 35 // The expected number of bytes for the CSD version’s MINIDUMP_STRING::Buffer.
37 const size_t kCSDVersionBytes = 36 const size_t kCSDVersionBytes =
38 csd_version_length * sizeof(MINIDUMP_STRING::Buffer[0]); 37 csd_version_length * sizeof(MINIDUMP_STRING::Buffer[0]);
39 const size_t kCSDVersionBytesWithNUL = 38 const size_t kCSDVersionBytesWithNUL =
40 kCSDVersionBytes + sizeof(MINIDUMP_STRING::Buffer[0]); 39 kCSDVersionBytes + sizeof(MINIDUMP_STRING::Buffer[0]);
41 40
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 MinidumpFileWriter minidump_file_writer; 287 MinidumpFileWriter minidump_file_writer;
289 MinidumpSystemInfoWriter system_info_writer; 288 MinidumpSystemInfoWriter system_info_writer;
290 minidump_file_writer.AddStream(&system_info_writer); 289 minidump_file_writer.AddStream(&system_info_writer);
291 290
292 StringFileWriter file_writer; 291 StringFileWriter file_writer;
293 ASSERT_DEATH(minidump_file_writer.WriteEverything(&file_writer), 292 ASSERT_DEATH(minidump_file_writer.WriteEverything(&file_writer),
294 "csd_version_"); 293 "csd_version_");
295 } 294 }
296 295
297 } // namespace 296 } // namespace
297 } // namespace test
298 } // namespace crashpad
OLDNEW
« no previous file with comments | « minidump/minidump_string_writer_test.cc ('k') | minidump/minidump_writable_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698