util/mac/mac_util_test.mm - Issue 635883002: Don’t use using directives (“using namespace”) in tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/mac/mac_util_test.mm

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: util/mac/mac_util_test.mm

diff --git a/util/mac/mac_util_test.mm b/util/mac/mac_util_test.mm

index 5c1366fb53b2bbb60b47c4ce5e98d22345f5c030..7bbba48404ce306068ccbb6cfa1b15d55817b25b 100644

--- a/util/mac/mac_util_test.mm

+++ b/util/mac/mac_util_test.mm

@@ -34,10 +34,10 @@

#undef catch

#endif

+namespace crashpad {

+namespace test {

namespace {

-using namespace crashpad;

// Runs /usr/bin/sw_vers with a single argument, |argument|, and places the

// command’s standard output into |output| after stripping the trailing newline.

// Fatal gtest assertions report tool failures, which the caller should check

@@ -147,3 +147,5 @@ TEST(MacUtil, MacModelAndBoard) {

}

} // namespace

+} // namespace test

+} // namespace crashpad

« no previous file with comments | « util/mac/launchd_test.mm ('k') | util/mac/mach_o_image_reader_test.cc » ('j') | no next file with comments »