Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: util/mach/task_memory_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/mach/symbolic_constants_mach_test.cc ('k') | util/misc/clock_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/mach/task_memory.h" 15 #include "util/mach/task_memory.h"
16 16
17 #include <mach/mach.h> 17 #include <mach/mach.h>
18 #include <string.h> 18 #include <string.h>
19 19
20 #include <algorithm> 20 #include <algorithm>
21 #include <string> 21 #include <string>
22 22
23 #include "base/mac/scoped_mach_port.h" 23 #include "base/mac/scoped_mach_port.h"
24 #include "base/mac/scoped_mach_vm.h" 24 #include "base/mac/scoped_mach_vm.h"
25 #include "base/memory/scoped_ptr.h" 25 #include "base/memory/scoped_ptr.h"
26 #include "gtest/gtest.h" 26 #include "gtest/gtest.h"
27 #include "util/test/mac/mach_errors.h" 27 #include "util/test/mac/mach_errors.h"
28 28
29 namespace crashpad {
30 namespace test {
29 namespace { 31 namespace {
30 32
31 using namespace crashpad;
32 using namespace crashpad::test;
33
34 TEST(TaskMemory, ReadSelf) { 33 TEST(TaskMemory, ReadSelf) {
35 vm_address_t address = 0; 34 vm_address_t address = 0;
36 const vm_size_t kSize = 4 * PAGE_SIZE; 35 const vm_size_t kSize = 4 * PAGE_SIZE;
37 kern_return_t kr = 36 kern_return_t kr =
38 vm_allocate(mach_task_self(), &address, kSize, VM_FLAGS_ANYWHERE); 37 vm_allocate(mach_task_self(), &address, kSize, VM_FLAGS_ANYWHERE);
39 ASSERT_EQ(KERN_SUCCESS, kr) << MachErrorMessage(kr, "vm_allocate"); 38 ASSERT_EQ(KERN_SUCCESS, kr) << MachErrorMessage(kr, "vm_allocate");
40 base::mac::ScopedMachVM vm_owner(address, mach_vm_round_page(kSize)); 39 base::mac::ScopedMachVM vm_owner(address, mach_vm_round_page(kSize));
41 40
42 char* region = reinterpret_cast<char*>(address); 41 char* region = reinterpret_cast<char*>(address);
43 for (size_t index = 0; index < kSize; ++index) { 42 for (size_t index = 0; index < kSize; ++index) {
(...skipping 501 matching lines...) Expand 10 before | Expand all | Expand 10 after
545 EXPECT_EQ("9", string); 544 EXPECT_EQ("9", string);
546 EXPECT_TRUE(mapped->ReadCString(10, &string)); 545 EXPECT_TRUE(mapped->ReadCString(10, &string));
547 EXPECT_EQ("", string); 546 EXPECT_EQ("", string);
548 547
549 // These are still out of range. 548 // These are still out of range.
550 EXPECT_FALSE(mapped->ReadCString(11, &string)); 549 EXPECT_FALSE(mapped->ReadCString(11, &string));
551 EXPECT_FALSE(mapped->ReadCString(12, &string)); 550 EXPECT_FALSE(mapped->ReadCString(12, &string));
552 } 551 }
553 552
554 } // namespace 553 } // namespace
554 } // namespace test
555 } // namespace crashpad
OLDNEW
« no previous file with comments | « util/mach/symbolic_constants_mach_test.cc ('k') | util/misc/clock_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698