client/simple_string_dictionary_test.cc - Issue 635883002: Don’t use using directives (“using namespace”) in tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/simple_string_dictionary_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: client/simple_string_dictionary_test.cc

diff --git a/client/simple_string_dictionary_test.cc b/client/simple_string_dictionary_test.cc

index df963ca5ea9d6e6deb3bd5f62c3354c3f16935d8..a55b5a31f16c911a74d1745992ab59e79970006e 100644

--- a/client/simple_string_dictionary_test.cc

+++ b/client/simple_string_dictionary_test.cc

@@ -17,10 +17,10 @@

#include "base/logging.h"

#include "gtest/gtest.h"

+namespace crashpad {

+namespace test {

namespace {

-using namespace crashpad;

TEST(SimpleStringDictionary, Entry) {

typedef TSimpleStringDictionary<5, 9, 15> TestMap;

TestMap map;

@@ -293,3 +293,5 @@ TEST(SimpleStringDictionaryDeathTest, NullKey) {

#endif

} // namespace

+} // namespace test

+} // namespace crashpad

« no previous file with comments | « client/capture_context_mac_test.cc ('k') | minidump/minidump_file_writer_test.cc » ('j') | no next file with comments »