Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: util/mach/exception_ports_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/mach/exception_behaviors_test.cc ('k') | util/mach/mach_extensions_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mach/exception_ports_test.cc
diff --git a/util/mach/exception_ports_test.cc b/util/mach/exception_ports_test.cc
index a5424a58f26c6eb7dcee20254c49915084f19d7c..56cda3c25fd16377af08167e3cbe9ce77ce28ff1 100644
--- a/util/mach/exception_ports_test.cc
+++ b/util/mach/exception_ports_test.cc
@@ -33,11 +33,10 @@
#include "util/test/mac/mach_errors.h"
#include "util/test/mac/mach_multiprocess.h"
+namespace crashpad {
+namespace test {
namespace {
-using namespace crashpad;
-using namespace crashpad::test;
-
// Calls GetExceptionPorts() on its |exception_ports| argument to look up the
// EXC_MASK_CRASH handler. If |expect_port| is not MACH_PORT_NULL, it expects to
// find a handler for this mask whose port matches |expect_port| and whose
@@ -574,3 +573,5 @@ TEST(ExceptionPorts, HostExceptionPorts) {
}
} // namespace
+} // namespace test
+} // namespace crashpad
« no previous file with comments | « util/mach/exception_behaviors_test.cc ('k') | util/mach/mach_extensions_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698