Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: minidump/minidump_misc_info_writer_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_memory_writer_test.cc ('k') | minidump/minidump_module_writer_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 10 matching lines...) Expand all
21 21
22 #include "base/basictypes.h" 22 #include "base/basictypes.h"
23 #include "base/strings/string16.h" 23 #include "base/strings/string16.h"
24 #include "base/strings/utf_string_conversions.h" 24 #include "base/strings/utf_string_conversions.h"
25 #include "gtest/gtest.h" 25 #include "gtest/gtest.h"
26 #include "minidump/minidump_file_writer.h" 26 #include "minidump/minidump_file_writer.h"
27 #include "minidump/minidump_test_util.h" 27 #include "minidump/minidump_test_util.h"
28 #include "util/file/string_file_writer.h" 28 #include "util/file/string_file_writer.h"
29 #include "util/stdlib/strlcpy.h" 29 #include "util/stdlib/strlcpy.h"
30 30
31 namespace crashpad {
32 namespace test {
31 namespace { 33 namespace {
32 34
33 using namespace crashpad;
34 using namespace crashpad::test;
35
36 template <typename T> 35 template <typename T>
37 void GetMiscInfoStream(const std::string& file_contents, const T** misc_info) { 36 void GetMiscInfoStream(const std::string& file_contents, const T** misc_info) {
38 const size_t kDirectoryOffset = sizeof(MINIDUMP_HEADER); 37 const size_t kDirectoryOffset = sizeof(MINIDUMP_HEADER);
39 const size_t kMiscInfoStreamOffset = 38 const size_t kMiscInfoStreamOffset =
40 kDirectoryOffset + sizeof(MINIDUMP_DIRECTORY); 39 kDirectoryOffset + sizeof(MINIDUMP_DIRECTORY);
41 const size_t kMiscInfoStreamSize = sizeof(T); 40 const size_t kMiscInfoStreamSize = sizeof(T);
42 const size_t kFileSize = kMiscInfoStreamOffset + kMiscInfoStreamSize; 41 const size_t kFileSize = kMiscInfoStreamOffset + kMiscInfoStreamSize;
43 42
44 ASSERT_EQ(kFileSize, file_contents.size()); 43 ASSERT_EQ(kFileSize, file_contents.size());
45 44
(...skipping 603 matching lines...) Expand 10 before | Expand all | Expand 10 after
649 arraysize(expected.BuildString)); 648 arraysize(expected.BuildString));
650 string16 debug_build_string_utf16 = base::UTF8ToUTF16(kDebugBuildString); 649 string16 debug_build_string_utf16 = base::UTF8ToUTF16(kDebugBuildString);
651 c16lcpy(expected.DbgBldStr, 650 c16lcpy(expected.DbgBldStr,
652 debug_build_string_utf16.c_str(), 651 debug_build_string_utf16.c_str(),
653 arraysize(expected.DbgBldStr)); 652 arraysize(expected.DbgBldStr));
654 653
655 ExpectMiscInfoEqual(&expected, observed); 654 ExpectMiscInfoEqual(&expected, observed);
656 } 655 }
657 656
658 } // namespace 657 } // namespace
658 } // namespace test
659 } // namespace crashpad
OLDNEW
« no previous file with comments | « minidump/minidump_memory_writer_test.cc ('k') | minidump/minidump_module_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698