Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: minidump/minidump_file_writer_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/simple_string_dictionary_test.cc ('k') | minidump/minidump_memory_writer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_file_writer_test.cc
diff --git a/minidump/minidump_file_writer_test.cc b/minidump/minidump_file_writer_test.cc
index 0ccc0f8efaa9d495d34c203e47feb76c1ec99360..611dce820390b84b591c3f2953ff28509fe4c3f6 100644
--- a/minidump/minidump_file_writer_test.cc
+++ b/minidump/minidump_file_writer_test.cc
@@ -26,11 +26,10 @@
#include "util/file/file_writer.h"
#include "util/file/string_file_writer.h"
+namespace crashpad {
+namespace test {
namespace {
-using namespace crashpad;
-using namespace crashpad::test;
-
TEST(MinidumpFileWriter, Empty) {
MinidumpFileWriter minidump_file;
StringFileWriter file_writer;
@@ -262,3 +261,5 @@ TEST(MinidumpFileWriterDeathTest, SameStreamType) {
}
} // namespace
+} // namespace test
+} // namespace crashpad
« no previous file with comments | « client/simple_string_dictionary_test.cc ('k') | minidump/minidump_memory_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698