Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: util/mach/symbolic_constants_mach_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/mach/mach_message_server_test.cc ('k') | util/mach/task_memory_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mach/symbolic_constants_mach_test.cc
diff --git a/util/mach/symbolic_constants_mach_test.cc b/util/mach/symbolic_constants_mach_test.cc
index 4bc17c814c82dfb695a923e20343d323f3a86ab2..0410f2e37333af342a0148eab19884d70fcfd25c 100644
--- a/util/mach/symbolic_constants_mach_test.cc
+++ b/util/mach/symbolic_constants_mach_test.cc
@@ -25,10 +25,10 @@
#define NUL_TEST_DATA(string) { string, arraysize(string) - 1 }
+namespace crashpad {
+namespace test {
namespace {
-using namespace crashpad;
-
// Options to use for normal tests, those that don’t require kAllowOr.
const StringToSymbolicConstantOptions kNormalOptions[] = {
0,
@@ -1062,3 +1062,5 @@ TEST(SymbolicConstantsMach, StringToThreadStateFlavor) {
}
} // namespace
+} // namespace test
+} // namespace crashpad
« no previous file with comments | « util/mach/mach_message_server_test.cc ('k') | util/mach/task_memory_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698