Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Side by Side Diff: snapshot/system_snapshot_mac_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « snapshot/cpu_context_mac_test.cc ('k') | util/file/string_file_writer_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "snapshot/system_snapshot_mac.h" 15 #include "snapshot/system_snapshot_mac.h"
16 16
17 #include <sys/time.h> 17 #include <sys/time.h>
18 #include <time.h> 18 #include <time.h>
19 19
20 #include <string> 20 #include <string>
21 21
22 #include "build/build_config.h" 22 #include "build/build_config.h"
23 #include "gtest/gtest.h" 23 #include "gtest/gtest.h"
24 #include "util/mac/mac_util.h" 24 #include "util/mac/mac_util.h"
25 #include "util/mac/process_reader.h" 25 #include "util/mac/process_reader.h"
26 #include "util/test/errors.h" 26 #include "util/test/errors.h"
27 27
28 namespace crashpad {
29 namespace test {
28 namespace { 30 namespace {
29 31
30 using namespace crashpad;
31 using namespace crashpad::test;
32
33 // SystemSnapshotMac objects would be cumbersome to construct in each test that 32 // SystemSnapshotMac objects would be cumbersome to construct in each test that
34 // requires one, because of the repetitive and mechanical work necessary to set 33 // requires one, because of the repetitive and mechanical work necessary to set
35 // up a ProcessReader and timeval, along with the checks to verify that these 34 // up a ProcessReader and timeval, along with the checks to verify that these
36 // operations succeed. This test fixture class handles the initialization work 35 // operations succeed. This test fixture class handles the initialization work
37 // so that individual tests don’t have to. 36 // so that individual tests don’t have to.
38 class SystemSnapshotMacTest : public testing::Test { 37 class SystemSnapshotMacTest : public testing::Test {
39 public: 38 public:
40 SystemSnapshotMacTest() 39 SystemSnapshotMacTest()
41 : Test(), 40 : Test(),
42 process_reader_(), 41 process_reader_(),
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 int dst_delta_seconds = daylight_offset_seconds - standard_offset_seconds; 165 int dst_delta_seconds = daylight_offset_seconds - standard_offset_seconds;
167 if (dst_delta_seconds != 60 * 60 && dst_delta_seconds != 30 * 60) { 166 if (dst_delta_seconds != 60 * 60 && dst_delta_seconds != 30 * 60) {
168 FAIL() << "dst_delta_seconds " << dst_delta_seconds; 167 FAIL() << "dst_delta_seconds " << dst_delta_seconds;
169 } 168 }
170 169
171 EXPECT_NE(standard_name, daylight_name); 170 EXPECT_NE(standard_name, daylight_name);
172 } 171 }
173 } 172 }
174 173
175 } // namespace 174 } // namespace
175 } // namespace test
176 } // namespace crashpad
OLDNEW
« no previous file with comments | « snapshot/cpu_context_mac_test.cc ('k') | util/file/string_file_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698