Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: snapshot/system_snapshot_mac_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/cpu_context_mac_test.cc ('k') | util/file/string_file_writer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/system_snapshot_mac_test.cc
diff --git a/snapshot/system_snapshot_mac_test.cc b/snapshot/system_snapshot_mac_test.cc
index 1f9d10174852cf337a0207220a6806d1d56caa09..bce1137d4efac06906317dff4fc869122be57c39 100644
--- a/snapshot/system_snapshot_mac_test.cc
+++ b/snapshot/system_snapshot_mac_test.cc
@@ -25,11 +25,10 @@
#include "util/mac/process_reader.h"
#include "util/test/errors.h"
+namespace crashpad {
+namespace test {
namespace {
-using namespace crashpad;
-using namespace crashpad::test;
-
// SystemSnapshotMac objects would be cumbersome to construct in each test that
// requires one, because of the repetitive and mechanical work necessary to set
// up a ProcessReader and timeval, along with the checks to verify that these
@@ -173,3 +172,5 @@ TEST_F(SystemSnapshotMacTest, TimeZone) {
}
} // namespace
+} // namespace test
+} // namespace crashpad
« no previous file with comments | « snapshot/cpu_context_mac_test.cc ('k') | util/file/string_file_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698