Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: util/synchronization/semaphore_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/stdlib/strnlen_test.cc ('k') | util/test/executable_path_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/synchronization/semaphore.h" 15 #include "util/synchronization/semaphore.h"
16 16
17 #include <pthread.h> 17 #include <pthread.h>
18 18
19 #include "gtest/gtest.h" 19 #include "gtest/gtest.h"
20 20
21 namespace crashpad {
22 namespace test {
21 namespace { 23 namespace {
22 24
23 using namespace crashpad;
24
25 TEST(Semaphore, Simple) { 25 TEST(Semaphore, Simple) {
26 Semaphore semaphore(1); 26 Semaphore semaphore(1);
27 semaphore.Wait(); 27 semaphore.Wait();
28 semaphore.Signal(); 28 semaphore.Signal();
29 } 29 }
30 30
31 struct ThreadMainInfo { 31 struct ThreadMainInfo {
32 pthread_t pthread; 32 pthread_t pthread;
33 Semaphore* semaphore; 33 Semaphore* semaphore;
34 size_t iterations; 34 size_t iterations;
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 semaphore.Signal(); 79 semaphore.Signal();
80 } 80 }
81 81
82 for (size_t index = 0; index < kThreads; ++index) { 82 for (size_t index = 0; index < kThreads; ++index) {
83 rv = pthread_join(info[index].pthread, NULL); 83 rv = pthread_join(info[index].pthread, NULL);
84 ASSERT_EQ(0, rv) << "pthread_join"; 84 ASSERT_EQ(0, rv) << "pthread_join";
85 } 85 }
86 } 86 }
87 87
88 } // namespace 88 } // namespace
89 } // namespace test
90 } // namespace crashpad
OLDNEW
« no previous file with comments | « util/stdlib/strnlen_test.cc ('k') | util/test/executable_path_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698