Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Side by Side Diff: client/capture_context_mac_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | client/simple_string_dictionary_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "client/capture_context_mac.h" 15 #include "client/capture_context_mac.h"
16 16
17 #include <mach/mach.h> 17 #include <mach/mach.h>
18 #include <stdint.h> 18 #include <stdint.h>
19 19
20 #include <algorithm> 20 #include <algorithm>
21 21
22 #include "build/build_config.h" 22 #include "build/build_config.h"
23 #include "gtest/gtest.h" 23 #include "gtest/gtest.h"
24 24
25 namespace crashpad {
26 namespace test {
25 namespace { 27 namespace {
26 28
27 using namespace crashpad;
28
29 // If the context structure has fields that tell whether it’s valid, such as 29 // If the context structure has fields that tell whether it’s valid, such as
30 // magic numbers or size fields, sanity-checks those fields for validity with 30 // magic numbers or size fields, sanity-checks those fields for validity with
31 // fatal gtest assertions. For other fields, where it’s possible to reason about 31 // fatal gtest assertions. For other fields, where it’s possible to reason about
32 // their validity based solely on their contents, sanity-checks via nonfatal 32 // their validity based solely on their contents, sanity-checks via nonfatal
33 // gtest assertions. 33 // gtest assertions.
34 void SanityCheckContext(NativeCPUContext* context) { 34 void SanityCheckContext(NativeCPUContext* context) {
35 #if defined(ARCH_CPU_X86) 35 #if defined(ARCH_CPU_X86)
36 ASSERT_EQ(x86_THREAD_STATE32, context->tsh.flavor); 36 ASSERT_EQ(x86_THREAD_STATE32, context->tsh.flavor);
37 ASSERT_EQ(static_cast<int>(x86_THREAD_STATE32_COUNT), context->tsh.count); 37 ASSERT_EQ(static_cast<int>(x86_THREAD_STATE32_COUNT), context->tsh.count);
38 #elif defined(ARCH_CPU_X86_64) 38 #elif defined(ARCH_CPU_X86_64)
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 } 145 }
146 146
147 TEST(CaptureContextMac, CaptureContext) { 147 TEST(CaptureContextMac, CaptureContext) {
148 TestCaptureContext(); 148 TestCaptureContext();
149 if (Test::HasFatalFailure()) { 149 if (Test::HasFatalFailure()) {
150 return; 150 return;
151 } 151 }
152 } 152 }
153 153
154 } // namespace 154 } // namespace
155 } // namespace test
156 } // namespace crashpad
OLDNEW
« no previous file with comments | « no previous file | client/simple_string_dictionary_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698