Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: minidump/minidump_module_writer_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_misc_info_writer_test.cc ('k') | minidump/minidump_string_writer_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "minidump/minidump_module_writer.h" 15 #include "minidump/minidump_module_writer.h"
16 16
17 #include <dbghelp.h> 17 #include <dbghelp.h>
18 #include <stdint.h> 18 #include <stdint.h>
19 #include <string.h> 19 #include <string.h>
20 20
21 #include "base/strings/utf_string_conversions.h" 21 #include "base/strings/utf_string_conversions.h"
22 #include "gtest/gtest.h" 22 #include "gtest/gtest.h"
23 #include "minidump/minidump_extensions.h" 23 #include "minidump/minidump_extensions.h"
24 #include "minidump/minidump_file_writer.h" 24 #include "minidump/minidump_file_writer.h"
25 #include "minidump/minidump_test_util.h" 25 #include "minidump/minidump_test_util.h"
26 #include "util/file/string_file_writer.h" 26 #include "util/file/string_file_writer.h"
27 #include "util/misc/uuid.h" 27 #include "util/misc/uuid.h"
28 28
29 namespace crashpad {
30 namespace test {
29 namespace { 31 namespace {
30 32
31 using namespace crashpad;
32 using namespace crashpad::test;
33
34 void GetModuleListStream(const std::string& file_contents, 33 void GetModuleListStream(const std::string& file_contents,
35 const MINIDUMP_MODULE_LIST** module_list) { 34 const MINIDUMP_MODULE_LIST** module_list) {
36 const size_t kDirectoryOffset = sizeof(MINIDUMP_HEADER); 35 const size_t kDirectoryOffset = sizeof(MINIDUMP_HEADER);
37 const size_t kModuleListStreamOffset = 36 const size_t kModuleListStreamOffset =
38 kDirectoryOffset + sizeof(MINIDUMP_DIRECTORY); 37 kDirectoryOffset + sizeof(MINIDUMP_DIRECTORY);
39 const size_t kModulesOffset = 38 const size_t kModulesOffset =
40 kModuleListStreamOffset + sizeof(MINIDUMP_MODULE_LIST); 39 kModuleListStreamOffset + sizeof(MINIDUMP_MODULE_LIST);
41 40
42 ASSERT_GE(file_contents.size(), kModulesOffset); 41 ASSERT_GE(file_contents.size(), kModulesOffset);
43 42
(...skipping 621 matching lines...) Expand 10 before | Expand all | Expand 10 after
665 MinidumpModuleListWriter module_list_writer; 664 MinidumpModuleListWriter module_list_writer;
666 MinidumpModuleWriter module_writer; 665 MinidumpModuleWriter module_writer;
667 module_list_writer.AddModule(&module_writer); 666 module_list_writer.AddModule(&module_writer);
668 minidump_file_writer.AddStream(&module_list_writer); 667 minidump_file_writer.AddStream(&module_list_writer);
669 668
670 StringFileWriter file_writer; 669 StringFileWriter file_writer;
671 ASSERT_DEATH(minidump_file_writer.WriteEverything(&file_writer), "name_"); 670 ASSERT_DEATH(minidump_file_writer.WriteEverything(&file_writer), "name_");
672 } 671 }
673 672
674 } // namespace 673 } // namespace
674 } // namespace test
675 } // namespace crashpad
OLDNEW
« no previous file with comments | « minidump/minidump_misc_info_writer_test.cc ('k') | minidump/minidump_string_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698